chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc - Issue 273223002: views: Make view::Views::GetPreferredSize() const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc

Issue 273223002: views: Make view::Views::GetPreferredSize() const. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: More compile fix for ToT Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc ('k') | chrome/browser/ui/views/apps/chrome_native_app_window_views.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc

index 68d159ab083e03ce17ed422491b66199c0f4b6e2..2af19573a3db21ca07ee0614d93cb279d0d5cd93 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc

@@ -74,7 +74,7 @@ class ExpandableContainerView : public views::View,

virtual ~DetailsView() {}

// views::View:

- virtual gfx::Size GetPreferredSize() OVERRIDE;

+ virtual gfx::Size GetPreferredSize() const OVERRIDE;

// Animates this to be a height proportional to |ratio|.

void AnimateToRatio(double ratio);

@@ -180,7 +180,7 @@ ExpandableContainerView::DetailsView::DetailsView(

layout->AddPaddingRow(0, views::kPanelVertMargin);

}

-gfx::Size ExpandableContainerView::DetailsView::GetPreferredSize() {

+gfx::Size ExpandableContainerView::DetailsView::GetPreferredSize() const {

gfx::Size size = views::View::GetPreferredSize();

return gfx::Size(size.width(), size.height() * visible_ratio_);

}