ash/frame/caption_buttons/frame_caption_button_container_view.cc - Issue 273223002: views: Make view::Views::GetPreferredSize() const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/frame/caption_buttons/frame_caption_button_container_view.cc

Issue 273223002: views: Make view::Views::GetPreferredSize() const. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: More compile fix for ToT Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/frame/caption_buttons/frame_caption_button_container_view.cc

diff --git a/ash/frame/caption_buttons/frame_caption_button_container_view.cc b/ash/frame/caption_buttons/frame_caption_button_container_view.cc

index 06103f46bd77d6fef7711c8dd5c33ea8e01d93f7..12bbb71a35cadd9e0fa774f31add9541abfec4ba 100644

--- a/ash/frame/caption_buttons/frame_caption_button_container_view.cc

+++ b/ash/frame/caption_buttons/frame_caption_button_container_view.cc

@@ -131,10 +131,10 @@ void FrameCaptionButtonContainerView::UpdateSizeButtonVisibility(

!force_hidden && frame_->widget_delegate()->CanMaximize());

}

-gfx::Size FrameCaptionButtonContainerView::GetPreferredSize() {

+gfx::Size FrameCaptionButtonContainerView::GetPreferredSize() const {

int width = 0;

for (int i = 0; i < child_count(); ++i) {

- views::View* child = child_at(i);

+ const views::View* child = child_at(i);

if (child->visible())

width += child_at(i)->GetPreferredSize().width();

}