Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 2732213008: Revert of android: Add draw completion for CompositorView (Closed)

Created:
3 years, 9 months ago by BigBossZhiling
Modified:
3 years, 9 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of android: Add draw completion for CompositorView (patchset #6 id:100001 of https://codereview.chromium.org/2716193002/ ) Reason for revert: Revert the patch because of bug 697804. Original issue's description: > android: Add draw completion for CompositorView > > Add a new callback from native CompositorImpl that corresponds to all > swap buffers. Then plumb it up to CompositorView and use it to implement > the draw completion imlementation for the SurfaceView. > > BUG=512636 > > Review-Url: https://codereview.chromium.org/2716193002 > Cr-Commit-Position: refs/heads/master@{#453965} > Committed: https://chromium.googlesource.com/chromium/src/+/eddd0d4f361b16d62eae38b198d6cedde1626186 TBR=aelias@chromium.org,changwan@chromium.org,dtrainor@chromium.org,tedchoc@chromium.org,boliu@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=512636, 697804

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -61 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java View 6 chunks +2 lines, -32 lines 0 comments Download
M chrome/browser/android/compositor/compositor_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/compositor/compositor_view.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 4 chunks +6 lines, -16 lines 0 comments Download
M content/public/browser/android/compositor_client.h View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
BigBossZhiling
Created Revert of android: Add draw completion for CompositorView
3 years, 9 months ago (2017-03-08 22:31:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732213008/1
3 years, 9 months ago (2017-03-08 22:31:44 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 9 months ago (2017-03-08 22:31:46 UTC) #5
BigBossZhiling
3 years, 9 months ago (2017-03-08 22:31:52 UTC) #6
boliu
lgtm add 697804 as well
3 years, 9 months ago (2017-03-08 22:32:27 UTC) #7
BigBossZhiling
On 2017/03/08 22:32:27, boliu wrote: > lgtm > > add 697804 as well I added ...
3 years, 9 months ago (2017-03-08 22:34:44 UTC) #8
boliu
On 2017/03/08 22:34:44, BigBossZhiling wrote: > On 2017/03/08 22:32:27, boliu wrote: > > lgtm > ...
3 years, 9 months ago (2017-03-08 22:35:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2732213008/1
3 years, 9 months ago (2017-03-08 22:44:04 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 22:48:05 UTC) #14
Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698