Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2732213003: Fix for parsing generic function types with Fasta. (Closed)

Created:
3 years, 9 months ago by scheglov
Modified:
3 years, 9 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for parsing generic function types with Fasta. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/fe4378d2c88efa34b49bd766c01446484d63b77a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -77 lines) Patch
M pkg/analyzer/lib/dart/ast/ast_factory.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/ast/ast_factory.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_test.dart View 1 chunk +0 lines, -74 lines 0 comments Download
M pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/listener.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 9 months ago (2017-03-07 18:36:06 UTC) #1
Paul Berry
lgtm
3 years, 9 months ago (2017-03-07 19:26:51 UTC) #2
scheglov
3 years, 9 months ago (2017-03-07 20:04:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fe4378d2c88efa34b49bd766c01446484d63b77a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698