Chromium Code Reviews| Index: third_party/WebKit/Source/core/mojo/MojoHandle.idl |
| diff --git a/third_party/WebKit/Source/core/mojo/MojoHandle.idl b/third_party/WebKit/Source/core/mojo/MojoHandle.idl |
| index 78a49ed0fd4be0c51ac155307da18422f4845550..f8daea3fe03d5c0ff692c9aab7ce66284c3811e7 100644 |
| --- a/third_party/WebKit/Source/core/mojo/MojoHandle.idl |
| +++ b/third_party/WebKit/Source/core/mojo/MojoHandle.idl |
| @@ -15,6 +15,11 @@ callback MojoWatchCallback = void (MojoResult result); |
| MojoResult writeMessage(BufferSource buffer, sequence<MojoHandle> handles); |
| MojoReadMessageResult readMessage(optional MojoReadMessageFlags flags); |
| + // TODO(alokp): Create DataPipeHandle, a subclass of MojoHandle |
| + // and move the following member functions. |
| + MojoWriteDataResult writeData(BufferSource buffer, optional MojoWriteDataFlags flags); |
|
yzshen1
2017/03/07 17:56:39
Is it the plan to add two-phase read/write in a fo
alokp
2017/03/07 19:34:20
Do you mean MojoBegin[End]ReadData? If so, yes we
|
| + MojoReadDataResult readData(MojoReadDataFlags flags, optional unsigned long numBytes, optional BufferSource buffer); |
|
alokp
2017/03/07 05:48:58
yzshen/jbroman: MojoReadData is pretty heavily ove
jbroman
2017/03/07 16:01:44
I don't feel strongly here.
To me this is a sligh
yzshen1
2017/03/07 17:56:39
I am fine with this. +CC rockot for API discussion
Ken Rockot(use gerrit already)
2017/03/07 18:09:51
Seems reasonable to me.
alokp
2017/03/07 19:34:20
Thanks for the feedback. I split readData into thr
|
| + |
| // TODO(alokp): Create SharedBufferHandle, a subclass of MojoHandle |
| // and move the following member functions. |
| MojoMapBufferResult mapBuffer(unsigned long offset, unsigned long numBytes); |