Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 273213002: Pass --nologfile-per-isolate to d8 in plot-timer-events calibration code (Closed)

Created:
6 years, 7 months ago by adamk
Modified:
6 years, 7 months ago
Reviewers:
Sven Panne, Yang
CC:
v8-dev
Visibility:
Public.

Description

Pass --nologfile-per-isolate to d8 in plot-timer-events calibration code This was broken by the removal of the default isolate.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M tools/plot-timer-events View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
adamk
It's not clear to me if this is the right way to fix this, or ...
6 years, 7 months ago (2014-05-09 21:15:17 UTC) #1
Sven Panne
On 2014/05/09 21:15:17, adamk wrote: > It's not clear to me if this is the ...
6 years, 7 months ago (2014-05-12 07:35:54 UTC) #2
Sven Panne
On 2014/05/09 21:15:17, adamk wrote: > It's not clear to me if this is the ...
6 years, 7 months ago (2014-05-12 07:35:55 UTC) #3
Yang
On 2014/05/12 07:35:55, Sven Panne wrote: > On 2014/05/09 21:15:17, adamk wrote: > > It's ...
6 years, 7 months ago (2014-05-12 07:37:35 UTC) #4
Yang
6 years, 7 months ago (2014-05-12 13:48:27 UTC) #5
On 2014/05/12 07:37:35, Yang wrote:
> On 2014/05/12 07:35:55, Sven Panne wrote:
> > On 2014/05/09 21:15:17, adamk wrote:
> > > It's not clear to me if this is the right way to fix this, or if d8 --prof
> > > should set --nologfile-per-isolate implicitly. Otherwise any user trying
to
> > use
> > > --prof will have to look at a per-isolate file instead of plain old
v8.log.
> > 
> > I am not totally sure, either: The current default of logfile_per_isolate is
> the
> > right thing for a multi-process multi-threaded thing like Chrome, but it's a
> > little bit uncomfortable for our happy small development world. Perhaps we
> > should have a small discussion offline...
> 
> I think as long as d8 has only one isolate, it should assume
> --nologfile-per-isolate. I can prepare a CL.

Fixed in https://codereview.chromium.org/276333002/

Powered by Google App Engine
This is Rietveld 408576698