Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: ui/display/mojo/display_constants_struct_traits.cc

Issue 2732093006: Write mojom and EnumTraits for display::HDCPState. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/display/mojo/display_constants_struct_traits.h ('k') | ui/display/mojo/display_struct_traits_test.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/display/mojo/display_constants_struct_traits.cc
diff --git a/ui/display/mojo/display_constants_struct_traits.cc b/ui/display/mojo/display_constants_struct_traits.cc
index fd710869c244dcafc36936dc2809db25cc1f469e..f94c41cea39f3a614ec303555b23205e4b4c9a11 100644
--- a/ui/display/mojo/display_constants_struct_traits.cc
+++ b/ui/display/mojo/display_constants_struct_traits.cc
@@ -96,4 +96,42 @@ bool EnumTraits<display::mojom::DisplayConnectionType,
return false;
}
+// static
+display::mojom::HDCPState
+EnumTraits<display::mojom::HDCPState, display::HDCPState>::ToMojom(
+ display::HDCPState type) {
+ switch (type) {
+ case display::HDCPState::HDCP_STATE_UNDESIRED:
+ return display::mojom::HDCPState::HDCP_STATE_UNDESIRED;
+
Daniel Erat 2017/03/09 14:46:32 i know you're just being consistent with the exist
thanhph 2017/03/09 15:33:11 Done, I remove new lines between 2 switch cases in
+ case display::HDCPState::HDCP_STATE_DESIRED:
+ return display::mojom::HDCPState::HDCP_STATE_DESIRED;
+
+ case display::HDCPState::HDCP_STATE_ENABLED:
+ return display::mojom::HDCPState::HDCP_STATE_ENABLED;
+ }
+ NOTREACHED();
+ return display::mojom::HDCPState::HDCP_STATE_UNDESIRED;
+}
+
+// static
+bool EnumTraits<display::mojom::HDCPState, display::HDCPState>::FromMojom(
+ display::mojom::HDCPState type,
+ display::HDCPState* out) {
+ switch (type) {
+ case display::mojom::HDCPState::HDCP_STATE_UNDESIRED:
+ *out = display::HDCPState::HDCP_STATE_UNDESIRED;
+ return true;
+
+ case display::mojom::HDCPState::HDCP_STATE_DESIRED:
+ *out = display::HDCPState::HDCP_STATE_DESIRED;
+ return true;
+
+ case display::mojom::HDCPState::HDCP_STATE_ENABLED:
+ *out = display::HDCPState::HDCP_STATE_ENABLED;
+ return true;
+ }
Daniel Erat 2017/03/09 14:46:32 nit: should this have a NOTREACHED() too?
thanhph 2017/03/09 15:33:12 The deserialization should fail if the code reache
+ return false;
+}
+
} // namespace mojo
« no previous file with comments | « ui/display/mojo/display_constants_struct_traits.h ('k') | ui/display/mojo/display_struct_traits_test.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698