third_party/WebKit/Source/bindings/scripts/v8_interface.py - Issue 2732093003: bindings: Add support for the record<K,V> WebIDL type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_interface.py

Issue 2732093003: bindings: Add support for the record<K,V> WebIDL type. (Closed)

Patch Set: s/isolate->GetCurrentContext()/context/ Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/scripts/v8_interface.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_interface.py b/third_party/WebKit/Source/bindings/scripts/v8_interface.py

index c405fb845ddfbce2106bc9058b12f08c6aa74e6d..a2fd8a7edacf81c48959ec5dc59d1bcceef032f8 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_interface.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_interface.py

@@ -1101,7 +1101,8 @@ def resolution_tests_methods(effective_overloads):

# Array in overloaded method: http://crbug.com/262383

yield '%s->IsArray()' % cpp_value, method

for idl_type, method in idl_types_methods:

- if idl_type.is_dictionary or idl_type.name == 'Dictionary' or idl_type.is_callback_interface:

+ if idl_type.is_dictionary or idl_type.name == 'Dictionary' or \

+ idl_type.is_callback_interface or idl_type.is_record_type:

# FIXME: should be '{1}->IsObject() && !{1}->IsRegExp()'.format(cpp_value)

# FIXME: the IsRegExp checks can be skipped if we've

# already generated tests for them.