Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_interface.py

Issue 2732093003: bindings: Add support for the record<K,V> WebIDL type. (Closed)
Patch Set: Address most review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/v8_interface.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_interface.py b/third_party/WebKit/Source/bindings/scripts/v8_interface.py
index 9f1c8b23b172911bd3015c0cadfe155f78b7ede9..074ab4949b10a593dccb63c98c14a118f909da1a 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_interface.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_interface.py
@@ -1099,7 +1099,8 @@ def resolution_tests_methods(effective_overloads):
# Array in overloaded method: http://crbug.com/262383
yield '%s->IsArray()' % cpp_value, method
for idl_type, method in idl_types_methods:
- if idl_type.is_dictionary or idl_type.name == 'Dictionary' or idl_type.is_callback_interface:
+ if idl_type.is_dictionary or idl_type.name == 'Dictionary' or \
+ idl_type.is_callback_interface or idl_type.is_record_type:
# FIXME: should be '{1}->IsObject() && !{1}->IsRegExp()'.format(cpp_value)
# FIXME: the IsRegExp checks can be skipped if we've
# already generated tests for them.

Powered by Google App Engine
This is Rietveld 408576698