third_party/WebKit/Source/bindings/core/v8/BUILD.gn - Issue 2732093003: bindings: Add support for the record<K,V> WebIDL type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/BUILD.gn

Issue 2732093003: bindings: Add support for the record<K,V> WebIDL type. (Closed)

Patch Set: Address most review comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/BUILD.gn

diff --git a/third_party/WebKit/Source/bindings/core/v8/BUILD.gn b/third_party/WebKit/Source/bindings/core/v8/BUILD.gn

index 8856cdcac72ba743e7b9efb3b0bad78777c8ffed..12dba60516da376a46722639b6f2768c32cd8de4 100644

--- a/third_party/WebKit/Source/bindings/core/v8/BUILD.gn

+++ b/third_party/WebKit/Source/bindings/core/v8/BUILD.gn

@@ -160,6 +160,8 @@ bindings_core_generated_union_type_files = [

"$bindings_core_v8_output_dir/ArrayBufferOrArrayBufferViewOrBlobOrDocumentOrStringOrFormDataOrURLSearchParams.h",

"$bindings_core_v8_output_dir/ArrayBufferOrArrayBufferViewOrBlobOrUSVString.cpp",

"$bindings_core_v8_output_dir/ArrayBufferOrArrayBufferViewOrBlobOrUSVString.h",

+ "$bindings_core_v8_output_dir/BooleanOrByteStringByteStringRecord.cpp",

+ "$bindings_core_v8_output_dir/BooleanOrByteStringByteStringRecord.h",

"$bindings_core_v8_output_dir/CSSStyleValueOrCSSStyleValueSequence.cpp",

"$bindings_core_v8_output_dir/CSSStyleValueOrCSSStyleValueSequence.h",

"$bindings_core_v8_output_dir/CSSStyleValueOrCSSStyleValueSequenceOrString.cpp",

@@ -182,6 +184,8 @@ bindings_core_generated_union_type_files = [

"$bindings_core_v8_output_dir/EventListenerOptionsOrBoolean.h",

"$bindings_core_v8_output_dir/FileOrUSVString.cpp",

"$bindings_core_v8_output_dir/FileOrUSVString.h",

+ "$bindings_core_v8_output_dir/FloatOrStringElementRecord.cpp",

+ "$bindings_core_v8_output_dir/FloatOrStringElementRecord.h",

"$bindings_core_v8_output_dir/HTMLElementOrLong.cpp",

"$bindings_core_v8_output_dir/HTMLElementOrLong.h",

"$bindings_core_v8_output_dir/HTMLImageElementOrHTMLVideoElementOrHTMLCanvasElementOrBlobOrImageDataOrImageBitmapOrOffscreenCanvas.cpp",