Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4401)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/settings/settings_ui/settings_ui.html

Issue 2732003003: Make initial focus consistent in all instances of cr-drawer. (Closed)
Patch Set: add quotes Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/md_history/app.html ('k') | ui/webui/resources/cr_elements/cr_drawer/cr_drawer.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_ui/settings_ui.html
diff --git a/chrome/browser/resources/settings/settings_ui/settings_ui.html b/chrome/browser/resources/settings/settings_ui/settings_ui.html
index 0616648c5f42f4dd2f4f2e7f930b624e3acb3e95..c1f67ff30533409975049253e433158814a6b23e 100644
--- a/chrome/browser/resources/settings/settings_ui/settings_ui.html
+++ b/chrome/browser/resources/settings/settings_ui/settings_ui.html
@@ -32,10 +32,6 @@
overflow: hidden; /* Prevent double scroll bar bugs. */
}
- .drawer-header {
- outline: none;
- }
-
.last {
display: flex;
justify-content: flex-end;
@@ -92,8 +88,8 @@
role="none"
show-menu>
</cr-toolbar>
- <dialog id="drawer" is="cr-drawer" on-close="onMenuClosed_">
- <div class="drawer-header" tabindex="-1">$i18n{settings}</div>
+ <dialog id="drawer" is="cr-drawer" on-close="onMenuClosed_"
+ title="$i18n{settings}">
<div class="drawer-content">
<template is="dom-if" id="drawerTemplate">
<settings-menu page-visibility="[[pageVisibility_]]"
« no previous file with comments | « chrome/browser/resources/md_history/app.html ('k') | ui/webui/resources/cr_elements/cr_drawer/cr_drawer.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698