Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Unified Diff: chrome/browser/resources/md_history/app.html

Issue 2732003003: Make initial focus consistent in all instances of cr-drawer. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/md_history/app.html
diff --git a/chrome/browser/resources/md_history/app.html b/chrome/browser/resources/md_history/app.html
index e7de32477bf67335219fa98e70b9b769a38ca0be..fbbe077dcb807e0149345f7fa7409488abc70b35 100644
--- a/chrome/browser/resources/md_history/app.html
+++ b/chrome/browser/resources/md_history/app.html
@@ -28,6 +28,10 @@
background: var(--md-toolbar-color);
}
+ .drawer-header {
+ outline: none;
tsergeant 2017/03/07 01:54:01 Nit: Can this live in cr-drawer directly, to avoid
Dan Beam 2017/03/07 01:57:36 if we create a slot and wrap it like in cr-dialog
tsergeant 2017/03/07 01:58:43 There's already some CSS in cr-drawer for .drawer-
Dan Beam 2017/03/07 02:28:35 I kind of meant: <dom-module id="cr-drawer"> <t
+ }
+
/* Sizing this with flex causes slow load performance, see
* crbug.com/618153. TODO(dbeam): is this still an issue? */
#main-container {
@@ -114,7 +118,7 @@
<template is="cr-lazy-render" id="drawer">
<dialog is="cr-drawer" swipe-open>
- <div class="drawer-header">$i18n{title}</div>
+ <div class="drawer-header" tabindex="-1">$i18n{title}</div>
<history-side-bar id="drawer-side-bar" class="drawer-content"
selected-page="{{selectedPage_}}"
show-footer="[[showSidebarFooter]]">
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698