chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc - Issue 273193004: Move some content url constants to /url.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc

Issue 273193004: Move some content url constants to /url. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing files. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/content_settings_pattern_parser.cc ('k') | chrome/common/extensions/manifest_handlers/content_scripts_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc

diff --git a/chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc b/chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc

index 284d3b81b9644ee9c502a839184819098c975a55..af1a5a27b868d2b84cde0f3bb95bb7677ce69be3 100644

--- a/chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc

+++ b/chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc

@@ -10,11 +10,11 @@

#include "base/strings/utf_string_conversions.h"

#include "base/values.h"

#include "chrome/common/extensions/extension_constants.h"

-#include "content/public/common/url_constants.h"

#include "extensions/common/error_utils.h"

#include "extensions/common/manifest.h"

#include "extensions/common/manifest_constants.h"

#include "extensions/common/url_pattern.h"

+#include "url/url_constants.h"

namespace keys = extensions::manifest_keys;

namespace errors = extensions::manifest_errors;

@@ -197,7 +197,7 @@ FileBrowserHandler* LoadFileBrowserHandler(

}

StringToLowerASCII(&filter);

if (!StartsWithASCII(filter,

- std::string(content::kFileSystemScheme) + ':',

+ std::string(url::kFileSystemScheme) + ':',

true)) {

*error = extensions::ErrorUtils::FormatErrorMessageUTF16(

errors::kInvalidURLPatternError, filter);