chrome/common/extensions/manifest_handlers/content_scripts_handler.cc - Issue 273193004: Move some content url constants to /url.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handlers/content_scripts_handler.cc

Issue 273193004: Move some content url constants to /url. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autocomplete/autocomplete_input.cc ('K') | « chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc ('k') | chrome/common/net/url_fixer_upper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_handlers/content_scripts_handler.cc

diff --git a/chrome/common/extensions/manifest_handlers/content_scripts_handler.cc b/chrome/common/extensions/manifest_handlers/content_scripts_handler.cc

index 9a699b2013259706083215fc04001ae426754493..aa9b4c7e9688a2cb3ac49a865e2ae01493076731 100644

--- a/chrome/common/extensions/manifest_handlers/content_scripts_handler.cc

+++ b/chrome/common/extensions/manifest_handlers/content_scripts_handler.cc

@@ -160,7 +160,7 @@ bool LoadUserScriptFromDictionary(const base::DictionaryValue* content_script,

pattern.valid_schemes() & ~URLPattern::SCHEME_CHROMEUI);

}

- if (pattern.MatchesScheme(content::kFileScheme) &&

+ if (pattern.MatchesScheme(url::kFileScheme) &&

!PermissionsData::CanExecuteScriptEverywhere(extension)) {

extension->set_wants_file_access(true);

if (!(extension->creation_flags() & Extension::ALLOW_FILE_ACCESS)) {