chrome/browser/history/history_service.cc - Issue 273193004: Move some content url constants to /url.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_service.cc

Issue 273193004: Move some content url constants to /url. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/history/history_service.cc

diff --git a/chrome/browser/history/history_service.cc b/chrome/browser/history/history_service.cc

index 6bf46eebda91646f46ed734a497562d9128ade44..c1899ea8e87e749027d1af85e3ac2ff3e0b2df8b 100644

--- a/chrome/browser/history/history_service.cc

+++ b/chrome/browser/history/history_service.cc

@@ -979,7 +979,7 @@ bool HistoryService::CanAddURL(const GURL& url) {

// TODO: We should allow kChromeUIScheme URLs if they have been explicitly

// typed. Right now, however, these are marked as typed even when triggered

// by a shortcut or menu action.

- if (url.SchemeIs(content::kJavaScriptScheme) ||

+ if (url.SchemeIs(url::kJavaScriptScheme) ||

url.SchemeIs(content::kChromeDevToolsScheme) ||

url.SchemeIs(content::kChromeUIScheme) ||

url.SchemeIs(content::kViewSourceScheme) ||