Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: pkg/front_end/lib/src/fasta/scanner/string_scanner.dart

Issue 2731863002: move comment tokens into preceedingComments field (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/scanner/string_scanner.dart
diff --git a/pkg/front_end/lib/src/fasta/scanner/string_scanner.dart b/pkg/front_end/lib/src/fasta/scanner/string_scanner.dart
index a81d4a862e3c7627c4ac04f7a3a7510f4ae5b7d8..555dbaec791cd6bcdd0e1e4dc3828ed5a5b8d85f 100644
--- a/pkg/front_end/lib/src/fasta/scanner/string_scanner.dart
+++ b/pkg/front_end/lib/src/fasta/scanner/string_scanner.dart
@@ -44,12 +44,13 @@ class StringScanner extends ArrayBasedScanner {
Token firstToken() => tokens.next;
Token previousToken() => tail;
- void appendSubstringToken(PrecedenceInfo info, int start, bool asciiOnly,
+ @override
+ StringToken createSubstringToken(
+ PrecedenceInfo info, int start, bool asciiOnly,
[int extraOffset = 0]) {
- tail.next = new StringToken.fromSubstring(
+ return new StringToken.fromSubstring(
info, string, start, scanOffset + extraOffset, tokenStart,
canonicalize: true);
- tail = tail.next;
}
bool atEndOfFile() => scanOffset >= string.length - 1;

Powered by Google App Engine
This is Rietveld 408576698