Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: content/browser/renderer_host/delegated_frame_host.h

Issue 2731793002: DelegatedFrameHost should not allocate a new local surface id on frame eviction (Closed)
Patch Set: c Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/delegated_frame_host.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_DELEGATED_FRAME_HOST_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_DELEGATED_FRAME_HOST_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_DELEGATED_FRAME_HOST_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_DELEGATED_FRAME_HOST_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <vector> 10 #include <vector>
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 // client. 171 // client.
172 bool TransformPointToCoordSpaceForView(const gfx::Point& point, 172 bool TransformPointToCoordSpaceForView(const gfx::Point& point,
173 RenderWidgetHostViewBase* target_view, 173 RenderWidgetHostViewBase* target_view,
174 gfx::Point* transformed_point); 174 gfx::Point* transformed_point);
175 175
176 // Exposed for tests. 176 // Exposed for tests.
177 cc::SurfaceId SurfaceIdForTesting() const { 177 cc::SurfaceId SurfaceIdForTesting() const {
178 return cc::SurfaceId(frame_sink_id_, local_surface_id_); 178 return cc::SurfaceId(frame_sink_id_, local_surface_id_);
179 } 179 }
180 180
181 const cc::LocalSurfaceId& LocalSurfaceIdForTesting() const { 181 bool HasFrameForTesting() const { return has_frame_; }
182 return local_surface_id_;
183 }
184 182
185 void OnCompositingDidCommitForTesting(ui::Compositor* compositor) { 183 void OnCompositingDidCommitForTesting(ui::Compositor* compositor) {
186 OnCompositingDidCommit(compositor); 184 OnCompositingDidCommit(compositor);
187 } 185 }
188 bool ReleasedFrontLockActiveForTesting() const { 186 bool ReleasedFrontLockActiveForTesting() const {
189 return !!released_front_lock_.get(); 187 return !!released_front_lock_.get();
190 } 188 }
191 void SetRequestCopyOfOutputCallbackForTesting( 189 void SetRequestCopyOfOutputCallbackForTesting(
192 const base::Callback<void(std::unique_ptr<cc::CopyOutputRequest>)>& 190 const base::Callback<void(std::unique_ptr<cc::CopyOutputRequest>)>&
193 callback) { 191 callback) {
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
332 request_copy_of_output_callback_for_testing_; 330 request_copy_of_output_callback_for_testing_;
333 331
334 // YUV readback pipeline. 332 // YUV readback pipeline.
335 std::unique_ptr<display_compositor::ReadbackYUVInterface> 333 std::unique_ptr<display_compositor::ReadbackYUVInterface>
336 yuv_readback_pipeline_; 334 yuv_readback_pipeline_;
337 335
338 std::unique_ptr<cc::ExternalBeginFrameSource> begin_frame_source_; 336 std::unique_ptr<cc::ExternalBeginFrameSource> begin_frame_source_;
339 337
340 bool needs_begin_frame_ = false; 338 bool needs_begin_frame_ = false;
341 339
340 bool has_frame_ = false;
341
342 std::unique_ptr<DelegatedFrameEvictor> delegated_frame_evictor_; 342 std::unique_ptr<DelegatedFrameEvictor> delegated_frame_evictor_;
343 }; 343 };
344 344
345 } // namespace content 345 } // namespace content
346 346
347 #endif // CONTENT_BROWSER_RENDERER_HOST_DELEGATED_FRAME_HOST_H_ 347 #endif // CONTENT_BROWSER_RENDERER_HOST_DELEGATED_FRAME_HOST_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/renderer_host/delegated_frame_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698