chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc - Issue 2731663002: Remove WmWindowProperty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc

Issue 2731663002: Remove WmWindowProperty (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/wm/window_mirror_view.cc ('k') | chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc » ('j') | chrome/browser/ui/ash/launcher/multi_profile_browser_status_monitor.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc

diff --git a/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc b/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc

index bf4b2022b740868c18438c3e42eed859474c3ae2..e6259252016837b4ebc6f2c0d08129e6fe0742c3 100644

--- a/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc

+++ b/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc

@@ -11,10 +11,10 @@

#include "ash/common/wm_lookup.h"

#include "ash/common/wm_shell.h"

#include "ash/common/wm_window.h"

-#include "ash/common/wm_window_property.h"

#include "ash/display/screen_orientation_controller_chromeos.h"

#include "ash/shared/app_types.h"

#include "ash/shell.h"

+#include "ash/wm/window_properties.h"

#include "ash/wm/window_state_aura.h"

#include "ash/wm/window_util.h"

#include "base/bind.h"

@@ -423,8 +423,7 @@ void ArcAppWindowLauncherController::AttachControllerToWindowIfNeeded(

base::MakeUnique<AppWindow>(task_id, info->app_shelf_id(), widget, this));

RegisterApp(info);

DCHECK(info->app_window()->controller());

- ash::WmWindow::Get(window)->SetIntProperty(ash::WmWindowProperty::SHELF_ID,

- info->app_window()->shelf_id());

+ window->SetProperty(ash::kShelfIDKey, info->app_window()->shelf_id());

if (ash::WmShell::Get()

->maximize_mode_controller()

->IsMaximizeModeWindowManagerEnabled()) {