Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: pkg/front_end/lib/src/fasta/source/source_loader.dart

Issue 2731633003: [Fasta] Include line starts (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/kernel_target.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/source/source_loader.dart
diff --git a/pkg/front_end/lib/src/fasta/source/source_loader.dart b/pkg/front_end/lib/src/fasta/source/source_loader.dart
index 5e508462945b3ac4b52d8aadfc046d5f5989957a..57769dcbda8cee37020ea27b818c5bb4a1328b0e 100644
--- a/pkg/front_end/lib/src/fasta/source/source_loader.dart
+++ b/pkg/front_end/lib/src/fasta/source/source_loader.dart
@@ -63,9 +63,7 @@ class SourceLoader<L> extends Loader<L> {
byteCount += bytes.length - 1;
ScannerResult result = scan(bytes);
Token token = result.tokens;
- if (!suppressLexicalErrors) {
- target.addLineStarts(library.fileUri, result.lineStarts);
- }
+ target.addLineStarts(library.fileUri, result.lineStarts);
ahe 2017/03/03 09:03:58 Are you sure this is necessary?
while (token is ErrorToken) {
if (!suppressLexicalErrors) {
ErrorToken error = token;
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/kernel_target.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698