Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2731633003: [Fasta] Include line starts (Closed)

Created:
3 years, 9 months ago by jensj
Modified:
3 years, 9 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jensj
3 years, 9 months ago (2017-03-03 07:49:24 UTC) #2
ahe
https://codereview.chromium.org/2731633003/diff/1/pkg/front_end/lib/src/fasta/source/source_loader.dart File pkg/front_end/lib/src/fasta/source/source_loader.dart (right): https://codereview.chromium.org/2731633003/diff/1/pkg/front_end/lib/src/fasta/source/source_loader.dart#newcode66 pkg/front_end/lib/src/fasta/source/source_loader.dart:66: target.addLineStarts(library.fileUri, result.lineStarts); Are you sure this is necessary?
3 years, 9 months ago (2017-03-03 09:03:58 UTC) #3
jensj
You seem to be right :)
3 years, 9 months ago (2017-03-03 09:19:13 UTC) #4
ahe
lgtm
3 years, 9 months ago (2017-03-03 09:22:19 UTC) #5
jensj
3 years, 9 months ago (2017-03-03 09:30:06 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f979537725a721b999abee8a6f80f84296c1a65e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698