Fix uses of NavigationEntries in RenderViewContextMenu.

chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
@@ skipping 205 matching lines @@
 
   // Verify that the referrer on the page matches |kEmptyReferrer|.
   std::string page_referrer;
   ASSERT_TRUE(content::ExecuteScriptAndExtractString(
       tab,
       "window.domAutomationController.send(window.document.referrer);",
       &page_referrer));
   ASSERT_EQ(kEmptyReferrer, page_referrer);
 }
 
+// Ensure that View Page Info won't crash if there is no visible entry.
+// See http://crbug.com/370863.
+IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest, ViewPageInfoWithNoEntry) {
+  // Create a new tab with no committed entry.
+  ui_test_utils::WindowedTabAddedNotificationObserver tab_observer(
+      content::NotificationService::AllSources());
+  ASSERT_TRUE(content::ExecuteScript(
+      browser()->tab_strip_model()->GetActiveWebContents(), "window.open();"));

[nasko, 2014/05/09 22:56:08]

Will the about:blank synchronous navigation issue a didCommitProvisionalLoad? If
yes, then I assume we aren't creating a navigation entry then?

[Charlie Reis, 2014/05/09 23:34:43]

Good question.  Looks like it does send a didCommitProvisionalLoad, but it does
so with a page_id of -1.  That makes us classify it as
NAVIGATION_TYPE_NAV_IGNORE in NavigationController, and thus we have no
committed entry afterward.

+  tab_observer.Wait();
+  content::WebContents* tab = tab_observer.GetTab();
+  EXPECT_FALSE(tab->GetController().GetLastCommittedEntry());
+  EXPECT_FALSE(tab->GetController().GetVisibleEntry());
+
+  // Create a context menu.
+  content::ContextMenuParams context_menu_params;
+  TestRenderViewContextMenu menu(tab->GetMainFrame(), context_menu_params);
+  menu.Init();
+
+  // The item shouldn't be enabled in the menu.
+  EXPECT_FALSE(menu.IsCommandIdEnabled(IDC_CONTENT_CONTEXT_VIEWPAGEINFO));
+
+  // Ensure that viewing page info doesn't crash even if you can get to it.
+  menu.ExecuteCommand(IDC_CONTENT_CONTEXT_VIEWPAGEINFO, 0);
+}
+
 }  // namespace