Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1949)

Unified Diff: net/cert/x509_certificate_openssl.cc

Issue 2731603002: Check TBSCertificate.algorithm and Certificate.signatureAlgorithm for (Closed)
Patch Set: Use rsleevi's background comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/x509_certificate_nss.cc ('k') | net/cert/x509_certificate_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/x509_certificate_openssl.cc
diff --git a/net/cert/x509_certificate_openssl.cc b/net/cert/x509_certificate_openssl.cc
index 730eef0d6acf3f65bdd4c01f46beb8ed826d79e8..30d9598a50ae32c58b4362d54d5dcd090461fd7f 100644
--- a/net/cert/x509_certificate_openssl.cc
+++ b/net/cert/x509_certificate_openssl.cc
@@ -377,24 +377,6 @@ void X509Certificate::GetPublicKeyInfo(OSCertHandle cert_handle,
}
}
-// static
-X509Certificate::SignatureHashAlgorithm
-X509Certificate::GetSignatureHashAlgorithm(OSCertHandle cert_handle) {
- int sig_alg = OBJ_obj2nid(cert_handle->sig_alg->algorithm);
- if (sig_alg == NID_md2WithRSAEncryption)
- return kSignatureHashAlgorithmMd2;
- if (sig_alg == NID_md4WithRSAEncryption)
- return kSignatureHashAlgorithmMd4;
- if (sig_alg == NID_md5WithRSAEncryption || sig_alg == NID_md5WithRSA)
- return kSignatureHashAlgorithmMd5;
- if (sig_alg == NID_sha1WithRSAEncryption || sig_alg == NID_dsaWithSHA ||
- sig_alg == NID_dsaWithSHA1 || sig_alg == NID_dsaWithSHA1_2 ||
- sig_alg == NID_sha1WithRSA || sig_alg == NID_ecdsa_with_SHA1) {
- return kSignatureHashAlgorithmSha1;
- }
- return kSignatureHashAlgorithmOther;
-}
-
bool X509Certificate::IsIssuedByEncoded(
const std::vector<std::string>& valid_issuers) {
if (valid_issuers.empty())
« no previous file with comments | « net/cert/x509_certificate_nss.cc ('k') | net/cert/x509_certificate_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698