Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: net/cert/x509_certificate_mac.cc

Issue 2731603002: Check TBSCertificate.algorithm and Certificate.signatureAlgorithm for (Closed)
Patch Set: Use rsleevi's background comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/x509_certificate_ios.cc ('k') | net/cert/x509_certificate_nss.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/x509_certificate_mac.cc
diff --git a/net/cert/x509_certificate_mac.cc b/net/cert/x509_certificate_mac.cc
index 26866404917784e043e947448b4bfad0d53047b0..3c3c8cfc94a56c4bd3b1eedab664f3ba7bb3603b 100644
--- a/net/cert/x509_certificate_mac.cc
+++ b/net/cert/x509_certificate_mac.cc
@@ -518,43 +518,6 @@ void X509Certificate::GetPublicKeyInfo(OSCertHandle cert_handle,
}
}
-X509Certificate::SignatureHashAlgorithm
-X509Certificate::GetSignatureHashAlgorithm(OSCertHandle cert_handle) {
- x509_util::CSSMCachedCertificate cached_cert;
- OSStatus status = cached_cert.Init(cert_handle);
- if (status)
- return kSignatureHashAlgorithmOther;
-
- x509_util::CSSMFieldValue signature_field;
- status =
- cached_cert.GetField(&CSSMOID_X509V1SignatureAlgorithm, &signature_field);
- if (status || !signature_field.field())
- return kSignatureHashAlgorithmOther;
-
- const CSSM_X509_ALGORITHM_IDENTIFIER* sig_algorithm =
- signature_field.GetAs<CSSM_X509_ALGORITHM_IDENTIFIER>();
- if (!sig_algorithm)
- return kSignatureHashAlgorithmOther;
-
- const CSSM_OID* alg_oid = &sig_algorithm->algorithm;
- if (CSSMOIDEqual(alg_oid, &CSSMOID_MD2WithRSA))
- return kSignatureHashAlgorithmMd2;
- if (CSSMOIDEqual(alg_oid, &CSSMOID_MD4WithRSA))
- return kSignatureHashAlgorithmMd4;
- if (CSSMOIDEqual(alg_oid, &CSSMOID_MD5WithRSA))
- return kSignatureHashAlgorithmMd5;
- if (CSSMOIDEqual(alg_oid, &CSSMOID_SHA1WithRSA) ||
- CSSMOIDEqual(alg_oid, &CSSMOID_SHA1WithRSA_OIW) ||
- CSSMOIDEqual(alg_oid, &CSSMOID_SHA1WithDSA) ||
- CSSMOIDEqual(alg_oid, &CSSMOID_SHA1WithDSA_CMS) ||
- CSSMOIDEqual(alg_oid, &CSSMOID_SHA1WithDSA_JDK) ||
- CSSMOIDEqual(alg_oid, &CSSMOID_ECDSA_WithSHA1)) {
- return kSignatureHashAlgorithmSha1;
- }
-
- return kSignatureHashAlgorithmOther;
-}
-
// static
bool X509Certificate::IsSelfSigned(OSCertHandle cert_handle) {
x509_util::CSSMCachedCertificate cached_cert;
« no previous file with comments | « net/cert/x509_certificate_ios.cc ('k') | net/cert/x509_certificate_nss.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698