Adding --directory option to git cl patch

Adding --directory option to git cl patch

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=228926

[M-A Ruel, 2013-10-15 13:09:07]

Use case?

[qsr, 2013-10-15 13:12:56]

On 2013/10/15 13:09:07, M-A Ruel wrote:
> Use case?

 I had the case when someone was uploading patches from a repo that he created
with a git svn clone from somewhere that was not trunk, but trunk/src (for
breakpad specifically). I then couldn't use git svn patch, as the base directory
was not the same.

[qsr, 2013-10-16 14:20:20]

gentle ping?

[M-A Ruel, 2013-10-16 16:10:11]

https://codereview.chromium.org/27316002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/27316002/diff/1/git_cl.py#newcode1867
git_cl.py:1867: parser.add_option('-d', '--directory', action='store',
dest='directory',
Remove dest argument. While at it, remove it on 'reject' and force and add
proper '--force' support.

You may want to use metavar='DIR' and use DIR instead of DIRECTORY in the help
string.

https://codereview.chromium.org/27316002/diff/1/git_cl.py#newcode1938
git_cl.py:1938: cmd.append('--directory')
cmd.extend(('--directory', directory))

[qsr, 2013-10-16 16:16:52]

https://codereview.chromium.org/27316002/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/27316002/diff/1/git_cl.py#newcode1867
git_cl.py:1867: parser.add_option('-d', '--directory', action='store',
dest='directory',
On 2013/10/16 16:10:12, M-A Ruel wrote:
> Remove dest argument. While at it, remove it on 'reject' and force and add
> proper '--force' support.
> 
> You may want to use metavar='DIR' and use DIR instead of DIRECTORY in the help
> string.

Done.

https://codereview.chromium.org/27316002/diff/1/git_cl.py#newcode1938
git_cl.py:1938: cmd.append('--directory')
On 2013/10/16 16:10:12, M-A Ruel wrote:
> cmd.extend(('--directory', directory))

Done.

[M-A Ruel, 2013-10-16 16:22:01]

lgtm

[commit-bot: I haz the power, 2013-10-16 16:22:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qsr@chromium.org/27316002/9001

[M-A Ruel, 2013-10-16 16:22:36]

On 2013/10/16 16:22:01, M-A Ruel wrote:
> lgtm

Note that since there's no test, you'll be bound to these lines of code for the
rest of your life.

[commit-bot: I haz the power, 2013-10-16 16:24:36]

Change committed as 228926