Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2731593002: Fix language/regress_28325 in precompiled mode (Closed)

Created:
3 years, 9 months ago by hausner
Modified:
3 years, 9 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix language/regress_28325 in precompiled mode This is a follow-up CL to https://codereview.chromium.org/2727803002/ That fixes the stack trace in precompiled code. BUG=#28770 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/356581ff76674f49d964a88080d443353cef7006

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/vm/code_descriptors.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
hausner
3 years, 9 months ago (2017-03-02 22:05:58 UTC) #3
rmacnak
LGTM
3 years, 9 months ago (2017-03-02 22:06:57 UTC) #4
hausner
3 years, 9 months ago (2017-03-02 22:12:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
356581ff76674f49d964a88080d443353cef7006 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698