ios/chrome/browser/BUILD.gn - Issue 2731553005: Introduced StoreKitTabHelper class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/BUILD.gn

Issue 2731553005: Introduced StoreKitTabHelper class (Closed)

Patch Set: rebased and address sdefresne's 2nd round comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/BUILD.gn

diff --git a/ios/chrome/browser/BUILD.gn b/ios/chrome/browser/BUILD.gn

index 76d8f48c83f7961861d52b12b5bb81d6997c9e5a..1f3d392b8f1397fd877cb3de2ad652f79d5cb670 100644

--- a/ios/chrome/browser/BUILD.gn

+++ b/ios/chrome/browser/BUILD.gn

@@ -57,7 +57,6 @@ source_set("browser") {

"procedural_block_types.h",

"root_coordinator.h",

"root_coordinator.mm",

- "storekit_launcher.h",

"tab_parenting_global_observer.cc",

"tab_parenting_global_observer.h",

"web_data_service_factory.cc",

@@ -101,6 +100,7 @@ source_set("browser") {

"//google_apis",

"//ios/chrome/app/strings",

"//ios/chrome/browser/browser_state",

+ "//ios/chrome/browser/store_kit",

rohitrao (ping after 24h) 2017/03/07 13:38:07 Does this target actually need to depend on store_

pkl (ping after 24h if needed) 2017/03/07 21:24:46 Doesn't seem necessary. Removed. Thanks!

"//ios/chrome/browser/sync/glue",

"//ios/chrome/common",

"//ios/net",