Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Unified Diff: pkg/front_end/lib/src/fasta/source/outline_builder.dart

Issue 2731553004: [Fasta] Offset and end offset on procedures (Closed)
Patch Set: Addressed comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/source/outline_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/source/outline_builder.dart b/pkg/front_end/lib/src/fasta/source/outline_builder.dart
index 215d2eb04fc582f20332322e26b1b2ac5526bb38..cf627a5c9663c03aa33ff85cc37782029abd6283 100644
--- a/pkg/front_end/lib/src/fasta/source/outline_builder.dart
+++ b/pkg/front_end/lib/src/fasta/source/outline_builder.dart
@@ -261,6 +261,7 @@ class OutlineBuilder extends UnhandledListener {
asyncModifier,
computeProcedureKind(getOrSet),
beginToken.charOffset,
+ endToken.charOffset,
nativeMethodName,
isTopLevel: true);
nativeMethodName = null;
@@ -311,8 +312,18 @@ class OutlineBuilder extends UnhandledListener {
int modifiers =
Modifier.validate(pop(), isAbstract: bodyKind == MethodBody.Abstract);
List<MetadataBuilder> metadata = pop();
- library.addProcedure(metadata, modifiers, returnType, name, typeVariables,
- formals, asyncModifier, kind, beginToken.charOffset, nativeMethodName,
+ library.addProcedure(
+ metadata,
+ modifiers,
+ returnType,
+ name,
+ typeVariables,
+ formals,
+ asyncModifier,
+ kind,
+ beginToken.charOffset,
+ endToken.charOffset,
+ nativeMethodName,
isTopLevel: false);
nativeMethodName = null;
}
@@ -472,7 +483,8 @@ class OutlineBuilder extends UnhandledListener {
List<String> constants = popList(count);
String name = pop();
List<MetadataBuilder> metadata = pop();
- library.addEnum(metadata, name, constants, enumKeyword.charOffset);
+ library.addEnum(
+ metadata, name, constants, enumKeyword.charOffset, endBrace.charOffset);
checkEmpty(enumKeyword.charOffset);
}
@@ -562,8 +574,16 @@ class OutlineBuilder extends UnhandledListener {
var name = pop();
int modifiers = Modifier.validate(pop());
List<MetadataBuilder> metadata = pop();
- library.addFactoryMethod(metadata, modifiers, name, formals, asyncModifier,
- redirectionTarget, beginToken.charOffset, nativeMethodName);
+ library.addFactoryMethod(
+ metadata,
+ modifiers,
+ name,
+ formals,
+ asyncModifier,
+ redirectionTarget,
+ beginToken.charOffset,
+ endToken.charOffset,
+ nativeMethodName);
nativeMethodName = null;
}
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/kernel_target.dart ('k') | pkg/front_end/lib/src/fasta/source/source_library_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698