Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 273153004: Revert of Handle TemplateURLService load failure better, and make some test correctness fixes that will be ne… (Closed)

Created:
6 years, 7 months ago by Alpha Left Google
Modified:
6 years, 7 months ago
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, James Su, Jered
Visibility:
Public.

Description

Revert of Handle TemplateURLService load failure better, and make some test correctness fixes that will be ne… (https://codereview.chromium.org/272573004/) Reason for revert: Seems to be causing use after free on Mac: http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/759 Original issue's description: > Handle TemplateURLService load failure better, and make some test correctness fixes that will be needed later. > > This also does a variety of miscellaneous cleanups to the modified files. > > BUG=364183 > TEST=none > R=jered@chromium.org, pkasting@chromium.org > TBR=engedy > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269329 TBR=pkasting@chromium.org,zea@chromium.org,jered@chromium.org,engedy@chromium.org,erikwright@chromium.org NOTREECHECKS=true NOTRY=true BUG=364183 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269637

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -369 lines) Patch
M chrome/browser/autocomplete/base_search_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profile_resetter/profile_resetter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/instant_service.h View 5 chunks +27 lines, -29 lines 0 comments Download
M chrome/browser/search/instant_service.cc View 9 chunks +96 lines, -70 lines 0 comments Download
M chrome/browser/search/instant_service_observer.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/search/instant_service_observer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/search/instant_service_unittest.cc View 4 chunks +19 lines, -34 lines 0 comments Download
M chrome/browser/search/instant_unittest_base.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/search/instant_unittest_base.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M chrome/browser/search_engines/default_search_pref_migration_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url.h View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/search_engines/template_url.cc View 2 chunks +0 lines, -35 lines 0 comments Download
M chrome/browser/search_engines/template_url_service.h View 5 chunks +12 lines, -17 lines 0 comments Download
M chrome/browser/search_engines/template_url_service.cc View 22 chunks +156 lines, -143 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_instant_controller.h View 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_instant_controller.cc View 5 chunks +19 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser_instant_controller_unittest.cc View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Alpha Left Google
6 years, 7 months ago (2014-05-10 21:06:07 UTC) #1 
Created Revert of Handle TemplateURLService load failure better, and make some
test correctness fixes that will be ne…

Powered by Google App Engine
This is Rietveld 408576698