Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 273153003: Remove stray platform_file.h from chrome and components (Closed)

Created:
6 years, 7 months ago by rvargas (doing something else)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, vandebo (ex-Chrome), nkostylev+watch_chromium.org, tzik, rpetterson, yoshiki+watch_chromium.org, rginda+watch_chromium.org, kinuko+watch, aandrey+blink_chromium.org, stevenjb+watch_chromium.org, markusheintz_, mkwst+watchlist_chromium.org, extensions-reviews_chromium.org, vsevik, grt+watch_chromium.org, marja+watch_chromium.org, devtools-reviews_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, fischman+watch_chromium.org, browser-components-watch_chromium.org, rouslan+spellwatch_chromium.org, nhiroki, feature-media-reviews_chromium.org, paulirish+reviews_chromium.org, oshima+watch_chromium.org, Lei Zhang, tfarina, mcasas+watch_chromium.org, yurys, tommycli, davemoore+watch_chromium.org, Greg Billock, wjia+watch_chromium.org, pfeldman
Visibility:
Public.

Description

Remove stray platform_file.h from chrome and components BUG=322664 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270166

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Remove "using" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -42 lines) Patch
M chrome/browser/bookmarks/bookmark_html_writer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_file_system_helper_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/resource_entry_conversion.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_file_system.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/component_updater/cld_component_installer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/devtools/devtools_file_system_indexer.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/sync_file_system/sync_file_system_api.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/updater/extension_downloader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/first_run/upgrade_util_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media/webrtc_log_util.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/iapps_data_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/iphoto_data_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/itunes_data_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_system_backend.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_validator_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/mtp_file_stream_reader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/picasa_file_util_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.h View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/media_galleries/linux/mtp_device_task_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_x_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/sandboxed_zip_analyzer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sessions/session_restore.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_context.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_context_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/help/help_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/setup/install_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/install_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/pepper/pepper_shared_memory_message_filter.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/utility/media_galleries/iphoto_library_parser.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/utility/media_galleries/itunes_library_parser.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/policy/core/common/config_dir_policy_loader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/policy/core/common/policy_loader_mac.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
rvargas (doing something else)
testing -> chrome Joao -> components PTAL.
6 years, 7 months ago (2014-05-13 01:06:49 UTC) #1
Lei Zhang
lgtm https://codereview.chromium.org/273153003/diff/20001/chrome/browser/devtools/devtools_file_system_indexer.cc File chrome/browser/devtools/devtools_file_system_indexer.cc (right): https://codereview.chromium.org/273153003/diff/20001/chrome/browser/devtools/devtools_file_system_indexer.cc#newcode26 chrome/browser/devtools/devtools_file_system_indexer.cc:26: using base::PassPlatformFile; Remove these two lines as well?
6 years, 7 months ago (2014-05-13 01:17:39 UTC) #2
rvargas (doing something else)
Thanks! https://codereview.chromium.org/273153003/diff/20001/chrome/browser/devtools/devtools_file_system_indexer.cc File chrome/browser/devtools/devtools_file_system_indexer.cc (right): https://codereview.chromium.org/273153003/diff/20001/chrome/browser/devtools/devtools_file_system_indexer.cc#newcode26 chrome/browser/devtools/devtools_file_system_indexer.cc:26: using base::PassPlatformFile; On 2014/05/13 01:17:40, Lei Zhang wrote: ...
6 years, 7 months ago (2014-05-13 01:45:59 UTC) #3
Joao da Silva
lgtm
6 years, 7 months ago (2014-05-13 08:35:19 UTC) #4
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-13 08:40:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/273153003/40001
6 years, 7 months ago (2014-05-13 08:41:05 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-13 10:24:57 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-13 11:44:30 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/153399)
6 years, 7 months ago (2014-05-13 11:44:30 UTC) #9
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 7 months ago (2014-05-13 17:57:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/273153003/40001
6 years, 7 months ago (2014-05-13 17:58:02 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 19:32:15 UTC) #12
Message was sent while issue was closed. 
Change committed as 270166

Powered by Google App Engine
This is Rietveld 408576698