Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: ios/chrome/browser/native_app_launcher/native_app_navigation_controller.h

Issue 2731443003: Removed CRWWebController dependency from NativeAppNavigationController. (Closed)
Patch Set: Fixed dependencies Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IOS_CHROME_BROWSER_NATIVE_APP_LAUNCHER_NATIVE_APP_NAVIGATION_CONTROLLER_ H_ 5 #ifndef IOS_CHROME_BROWSER_NATIVE_APP_LAUNCHER_NATIVE_APP_NAVIGATION_CONTROLLER_ H_
6 #define IOS_CHROME_BROWSER_NATIVE_APP_LAUNCHER_NATIVE_APP_NAVIGATION_CONTROLLER_ H_ 6 #define IOS_CHROME_BROWSER_NATIVE_APP_LAUNCHER_NATIVE_APP_NAVIGATION_CONTROLLER_ H_
7 7
8 #import <Foundation/Foundation.h> 8 #import <Foundation/Foundation.h>
9 9
10 #import "ios/chrome/browser/native_app_launcher/native_app_navigation_controller _protocol.h" 10 #import "ios/chrome/browser/native_app_launcher/native_app_navigation_controller _protocol.h"
pkl (ping after 24h if needed) 2017/03/03 16:45:30 Can this be moved to the .mm file too?
Eugene But (OOO till 7-30) 2017/03/03 19:42:07 Done.
11 #import "ios/web/public/web_state/crw_web_controller_observer.h" 11 #import "ios/web/public/web_state/crw_web_controller_observer.h"
pkl (ping after 24h if needed) 2017/03/03 16:45:30 Can you remove this #import too?
Eugene But (OOO till 7-30) 2017/03/03 19:42:07 Done.
12 12
13 @class Tab; 13 @class Tab;
14 14
15 namespace net { 15 namespace net {
16 class URLRequestContextGetter; 16 class URLRequestContextGetter;
17 } // namespace net 17 } // namespace net
18 18
19 namespace web { 19 namespace web {
20 class WebState; 20 class WebState;
21 } // namespace web 21 } // namespace web
22 22
23 // NativeAppNavigationController brings up a GAL Infobar if the webpage directs 23 // NativeAppNavigationController brings up a GAL Infobar if the webpage directs
24 // it to do so and there are no other circumstances that would suppress its 24 // it to do so and there are no other circumstances that would suppress its
25 // display. 25 // display.
26 @interface NativeAppNavigationController 26 @interface NativeAppNavigationController : NSObject
27 : NSObject<CRWWebControllerObserver, NativeAppNavigationControllerProtocol>
28 27
29 // Designated initializer. The use of |tab| will be phased out in the future 28 // Designated initializer. The use of |tab| will be phased out in the future
30 // when all the information needed can be fulfilled by |webState|. Use this 29 // when all the information needed can be fulfilled by |webState|. Use this
31 // instead of -init. 30 // instead of -init.
32 - (instancetype)initWithWebState:(web::WebState*)webState 31 - (instancetype)initWithWebState:(web::WebState*)webState
33 requestContextGetter:(net::URLRequestContextGetter*)context 32 requestContextGetter:(net::URLRequestContextGetter*)context
34 tab:(Tab*)tab NS_DESIGNATED_INITIALIZER; 33 tab:(Tab*)tab NS_DESIGNATED_INITIALIZER;
35 34
36 - (instancetype)init NS_UNAVAILABLE; 35 - (instancetype)init NS_UNAVAILABLE;
37 36
38 // Copies the list of applications possibly being installed and register to be 37 // Copies the list of applications possibly being installed and register to be
39 // notified of their installation. 38 // notified of their installation.
40 - (void)copyStateFrom:(NativeAppNavigationController*)controller; 39 - (void)copyStateFrom:(NativeAppNavigationController*)controller;
41 @end 40 @end
42 41
43 #endif // IOS_CHROME_BROWSER_NATIVE_APP_LAUNCHER_NATIVE_APP_NAVIGATION_CONTROLL ER_H_ 42 #endif // IOS_CHROME_BROWSER_NATIVE_APP_LAUNCHER_NATIVE_APP_NAVIGATION_CONTROLL ER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698