Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4969)

Unified Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 2731403005: MD Settings: Privacy: Show dialog when changing do-not-track (Closed)
Patch Set: Rebase Use on-settings-boolean-control-change Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/privacy_page/privacy_page.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
diff --git a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
index 3bdaf7c6a43a4c1e95c450f33965ac79fee91ad4..26c34769a3dfc9475cbf8c552a5370c26ca92ca1 100644
--- a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
+++ b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
@@ -1430,33 +1430,34 @@ void AddPrintingStrings(content::WebUIDataSource* html_source) {
void AddPrivacyStrings(content::WebUIDataSource* html_source,
Profile* profile) {
LocalizedString localized_strings[] = {
- {"privacyPageTitle", IDS_SETTINGS_PRIVACY},
- {"linkDoctorPref", IDS_SETTINGS_LINKDOCTOR_PREF},
- {"searchSuggestPref", IDS_SETTINGS_SUGGEST_PREF},
- {"networkPredictionEnabled",
- IDS_SETTINGS_NETWORK_PREDICTION_ENABLED_DESCRIPTION},
- {"safeBrowsingEnableProtection",
- IDS_SETTINGS_SAFEBROWSING_ENABLEPROTECTION},
- {"spellingPref", IDS_SETTINGS_SPELLING_PREF},
- {"spellingDescription", IDS_SETTINGS_SPELLING_DESCRIPTION},
+ {"privacyPageTitle", IDS_SETTINGS_PRIVACY},
+ {"linkDoctorPref", IDS_SETTINGS_LINKDOCTOR_PREF},
+ {"searchSuggestPref", IDS_SETTINGS_SUGGEST_PREF},
+ {"networkPredictionEnabled",
+ IDS_SETTINGS_NETWORK_PREDICTION_ENABLED_DESCRIPTION},
+ {"safeBrowsingEnableProtection",
+ IDS_SETTINGS_SAFEBROWSING_ENABLEPROTECTION},
+ {"spellingPref", IDS_SETTINGS_SPELLING_PREF},
+ {"spellingDescription", IDS_SETTINGS_SPELLING_DESCRIPTION},
#if defined(OS_CHROMEOS)
- {"enableLogging", IDS_SETTINGS_ENABLE_LOGGING_DIAGNOSTIC_AND_USAGE_DATA},
+ {"enableLogging", IDS_SETTINGS_ENABLE_LOGGING_DIAGNOSTIC_AND_USAGE_DATA},
#else
- {"enableLogging", IDS_SETTINGS_ENABLE_LOGGING},
+ {"enableLogging", IDS_SETTINGS_ENABLE_LOGGING},
#endif
- {"doNotTrack", IDS_SETTINGS_ENABLE_DO_NOT_TRACK},
- {"enableContentProtectionAttestation",
- IDS_SETTINGS_ENABLE_CONTENT_PROTECTION_ATTESTATION},
- {"wakeOnWifi", IDS_SETTINGS_WAKE_ON_WIFI_DESCRIPTION},
- {"manageCertificates", IDS_SETTINGS_MANAGE_CERTIFICATES},
- {"manageCertificatesDescription",
- IDS_SETTINGS_MANAGE_CERTIFICATES_DESCRIPTION},
- {"contentSettings", IDS_SETTINGS_CONTENT_SETTINGS},
- {"siteSettings", IDS_SETTINGS_SITE_SETTINGS},
- {"siteSettingsDescription", IDS_SETTINGS_SITE_SETTINGS_DESCRIPTION},
- {"clearBrowsingData", IDS_SETTINGS_CLEAR_DATA},
- {"clearBrowsingDataDescription", IDS_SETTINGS_CLEAR_DATA_DESCRIPTION},
- {"titleAndCount", IDS_SETTINGS_TITLE_AND_COUNT},
+ {"doNotTrack", IDS_SETTINGS_ENABLE_DO_NOT_TRACK},
+ {"doNotTrackDialogTitle", IDS_SETTINGS_ENABLE_DO_NOT_TRACK_DIALOG_TITLE},
+ {"enableContentProtectionAttestation",
+ IDS_SETTINGS_ENABLE_CONTENT_PROTECTION_ATTESTATION},
+ {"wakeOnWifi", IDS_SETTINGS_WAKE_ON_WIFI_DESCRIPTION},
+ {"manageCertificates", IDS_SETTINGS_MANAGE_CERTIFICATES},
+ {"manageCertificatesDescription",
+ IDS_SETTINGS_MANAGE_CERTIFICATES_DESCRIPTION},
+ {"contentSettings", IDS_SETTINGS_CONTENT_SETTINGS},
+ {"siteSettings", IDS_SETTINGS_SITE_SETTINGS},
+ {"siteSettingsDescription", IDS_SETTINGS_SITE_SETTINGS_DESCRIPTION},
+ {"clearBrowsingData", IDS_SETTINGS_CLEAR_DATA},
+ {"clearBrowsingDataDescription", IDS_SETTINGS_CLEAR_DATA_DESCRIPTION},
+ {"titleAndCount", IDS_SETTINGS_TITLE_AND_COUNT},
};
AddLocalizedStringsBulk(html_source, localized_strings,
arraysize(localized_strings));
@@ -1472,6 +1473,11 @@ void AddPrivacyStrings(content::WebUIDataSource* html_source,
IDS_SETTINGS_IMPROVE_BROWSING_EXPERIENCE,
base::ASCIIToUTF16(chrome::kPrivacyLearnMoreURL)));
html_source->AddString(
+ "doNotTrackDialogMessage",
+ l10n_util::GetStringFUTF16(
+ IDS_SETTINGS_ENABLE_DO_NOT_TRACK_DIALOG_TEXT,
+ base::ASCIIToUTF16(chrome::kDoNotTrackLearnMoreURL)));
+ html_source->AddString(
"exceptionsLearnMoreURL",
base::ASCIIToUTF16(chrome::kContentSettingsExceptionsLearnMoreURL));
}
« no previous file with comments | « chrome/browser/resources/settings/privacy_page/privacy_page.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698