MD Settings: Privacy: Show dialog when changing do-not-track

chrome/browser/resources/settings/privacy_page/privacy_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-privacy-page' is the settings page containing privacy and
  * security settings.
  */
 (function() {
@@ skipping 59 matching lines @@
     safeBrowsingExtendedReportingPref_: {
       type: Object,
       value: function() {
         return /** @type {chrome.settingsPrivate.PrefObject} */({});
       },
     },
 
     /** @private */
     showClearBrowsingDataDialog_: Boolean,
 
+    /** @private */
+    showDoNotTrackDialog_: {
+      type: Boolean,
+      value: false,
+    },
+
     /**
      * Used for HTML bindings. This is defined as a property rather than within
      * the ready callback, because the value needs to be available before
      * local DOM initialization - otherwise, the toggle has unexpected behavior.
      * @private
      */
     networkPredictionEnum_: {
       type: Object,
       value: NetworkPredictionOptions,
     },
   },
 
+  listeners: {
+    'doNotTrackDialogIf.dom-change': 'onDoNotTrackDomChange_',
+  },
+
   ready: function() {
     this.ContentSettingsTypes = settings.ContentSettingsTypes;
 
     this.browserProxy_ = settings.PrivacyPageBrowserProxyImpl.getInstance();
 
 // <if expr="_google_chrome and not chromeos">
     var setMetricsReportingPref = this.setMetricsReportingPref_.bind(this);
     this.addWebUIListener('metrics-reporting-change', setMetricsReportingPref);
     this.browserProxy_.getMetricsReporting().then(setMetricsReportingPref);
 // </if>
 
     var setSber = this.setSafeBrowsingExtendedReporting_.bind(this);
     this.addWebUIListener('safe-browsing-extended-reporting-change', setSber);
     this.browserProxy_.getSafeBrowsingExtendedReporting().then(setSber);
   },
 
   /** @protected */
   currentRouteChanged: function() {
     this.showClearBrowsingDataDialog_ =
         settings.getCurrentRoute() == settings.Route.CLEAR_BROWSER_DATA;
   },
 
+  /**
+   * @param {Event} event
+   * @private
+   */
+  onDoNotTrackDomChange_: function(event) {
+    if (this.showDoNotTrackDialog_)
+      this.maybeShowDoNotTrackDialog_();
+  },
+
+  /**
+   * Handles the change event for the do-not-track toggle. Shows a
+   * confirmation dialog when enabling the setting.
+   * @param {{target: !SettingsToggleButtonElement}} event

[Dan Beam, 2017/03/14 04:59:19]

I think this type is weird

[stevenjb, 2017/03/14 18:35:56]

'weird' is not very helpful, please elaborate.

[Dan Beam, 2017/03/14 18:38:21]

@param {Event} event

var target = /** !SettingsToggleButtonElement */(event.target);

i think is more correcter

[stevenjb, 2017/03/14 19:18:23]

Done.

+   * @private
+   */
+  onDoNotTrackChange_: function(event) {
+    if (!event.target.checked) {
+      // Always allow disabling the pref.
+      event.target.sendPrefChange();
+      return;
+    }
+    this.showDoNotTrackDialog_ = true;
+    // If the dialog has already been stamped, show it. Otherwise it will be
+    // shown in onDomChange_.
+    this.maybeShowDoNotTrackDialog_();
+  },
+
+  /** @private */
+  maybeShowDoNotTrackDialog_: function() {
+    var dialog = this.$$('#confirmDoNotTrackDialog');
+    if (dialog && !dialog.open)
+      dialog.showModal();
+  },
+
+  /** @private */
+  closeDoNotTrackDialog_: function() {
+    this.$$('#confirmDoNotTrackDialog').close();
+    this.showDoNotTrackDialog_ = false;
+  },
+
+  /**
+   * Handles the shared proxy confirmation dialog 'Confirm' button.
+   * @private
+   */
+  onDoNotTrackDialogConfirm_: function() {
+    /** @type {!SettingsToggleButtonElement} */ (this.$.doNotTrack)
+        .sendPrefChange();
+    this.closeDoNotTrackDialog_();
+  },
+
+  /**
+   * Handles the shared proxy confirmation dialog 'Cancel' button or a cancel
+   * event.
+   * @private
+   */
+  onDoNotTrackDialogCancel_: function() {
+    /** @type {!SettingsToggleButtonElement} */ (this.$.doNotTrack)
+        .resetToPrefValue();
+    this.closeDoNotTrackDialog_();
+  },
+
   /** @private */
   onManageCertificatesTap_: function() {
 // <if expr="use_nss_certs">
     settings.navigateTo(settings.Route.CERTIFICATES);
 // </if>
 // <if expr="is_win or is_macosx">
     this.browserProxy_.showManageSSLCertificates();
 // </if>
   },
 
@@ skipping 117 matching lines @@
                  : this.i18n('siteSettingsBlocked');
   },
 
   /** @private */
   getProtectedContentIdentifiersLabel_: function(value) {
     return value ? this.i18n('siteSettingsProtectedContentEnableIdentifiers')
                  : this.i18n('siteSettingsBlocked');
   },
 });
 })();