Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/Dialog.js

Issue 2731383002: [DevTools] Make touch emulation work with OOPIF. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/ui/Dialog.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js b/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js
index cace1a296af311e3c4a53e4de98a49a7b21dcea4..b905558849c8ab93c35bc1a815e82890b37ebd7c 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js
@@ -61,7 +61,7 @@ UI.Dialog = class extends UI.GlassPane {
var document = /** @type {!Document} */ (
where instanceof Document ? where : (where || UI.inspectorView.element).ownerDocument);
if (UI.Dialog._instance)
- UI.Dialog._instance.detach();
caseq 2017/03/07 00:43:07 Wow! How did this work? Should this be a separate
dgozman 2017/03/07 21:57:01 Yeah, made a separate patch.
+ UI.Dialog._instance.hide();
UI.Dialog._instance = this;
this._disableTabIndexOnElements(document);
super.show(document);
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698