Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Unified Diff: third_party/WebKit/public/web/WebFrameSerializer.h

Issue 2731293004: Move the writing of the MHTML footer to the browser process. (Closed)
Patch Set: Comments and naming changes. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebFrameSerializer.h
diff --git a/third_party/WebKit/public/web/WebFrameSerializer.h b/third_party/WebKit/public/web/WebFrameSerializer.h
index 38ce57ac7f833521e2756aeacc92ccc8f0910f70..ebf6dde0965505eb80d3c975dafe4f04345965bc 100644
--- a/third_party/WebKit/public/web/WebFrameSerializer.h
+++ b/third_party/WebKit/public/web/WebFrameSerializer.h
@@ -95,14 +95,6 @@ class WebFrameSerializer {
WebLocalFrame*,
MHTMLPartsGenerationDelegate*);
- // Generates and returns an MHTML footer.
- //
- // Same |boundary| needs to used for all generateMHTMLHeader and
- // generateMHTMLParts and generateMHTMLFooter calls that belong to the same
- // MHTML document (see also rfc1341, section 7.2.1, "boundary" description).
- BLINK_EXPORT static WebThreadSafeData generateMHTMLFooter(
- const WebString& boundary);
dcheng 2017/03/09 01:56:51 For symmetry, it would be nice to remove generateM
carlosk 2017/03/09 22:03:36 I am still considering it (you can see it mentione
dcheng 2017/03/09 22:08:46 My concern is that the interaction between Blink a
carlosk 2017/03/09 23:07:29 Acknowledged.
dcheng 2017/03/09 23:09:17 To clarify, does that mean you'll be investigating
carlosk 2017/03/09 23:13:45 Not now. I will keep the linked issue (https://crb
-
// IMPORTANT:
// The API below is an older implementation of frame serialization that
// will be removed soon.

Powered by Google App Engine
This is Rietveld 408576698