content/browser/download/mhtml_generation_manager.h - Issue 2731293004: Move the writing of the MHTML footer to the browser process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/mhtml_generation_manager.h

Issue 2731293004: Move the writing of the MHTML footer to the browser process. (Closed)

Patch Set: Comments and naming changes. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/mhtml_generation_manager.h

diff --git a/content/browser/download/mhtml_generation_manager.h b/content/browser/download/mhtml_generation_manager.h

index fa5842bd2bd8a4373e9b663e5c9be0fd25917656..8dbdadb1b41f4397e789e95793414006f3c4cca8 100644

--- a/content/browser/download/mhtml_generation_manager.h

+++ b/content/browser/download/mhtml_generation_manager.h

@@ -76,7 +76,8 @@ class MHTMLGenerationManager {

void JobFinished(Job* job, MhtmlSaveStatus save_status);

// Called on the UI thread after the file got finalized and we have its size.

- void OnFileClosed(int job_id, MhtmlSaveStatus save_status, int64_t file_size);

+ void OnFileClosed(int job_id,

+ std::tuple<MhtmlSaveStatus, int64_t> save_status_size);

// Creates and registers a new job.

Job* NewJob(WebContents* web_contents,