Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: components/subresource_filter/core/browser/ruleset_service_unittest.cc

Issue 2731283009: Swap ownership of RulesetService and the content delegate (Closed)
Patch Set: engedy review Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/subresource_filter/core/browser/ruleset_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/subresource_filter/core/browser/ruleset_service_unittest.cc
diff --git a/components/subresource_filter/core/browser/ruleset_service_unittest.cc b/components/subresource_filter/core/browser/ruleset_service_unittest.cc
index 0e300937b96fe8d79bce1411eddf41b6b4b92f6d..dccef00822dacd4d45b4f3f2a7e8f85f8e415f15 100644
--- a/components/subresource_filter/core/browser/ruleset_service_unittest.cc
+++ b/components/subresource_filter/core/browser/ruleset_service_unittest.cc
@@ -145,8 +145,7 @@ class SubresourceFilteringRulesetServiceTest : public ::testing::Test {
public:
SubresourceFilteringRulesetServiceTest()
: task_runner_(new base::TestSimpleTaskRunner),
- task_runner_handle_(task_runner_),
- mock_delegate_(nullptr) {}
+ task_runner_handle_(task_runner_) {}
protected:
void SetUp() override {
@@ -172,15 +171,14 @@ class SubresourceFilteringRulesetServiceTest : public ::testing::Test {
}
void ResetRulesetService() {
+ mock_delegate_ = base::MakeUnique<MockRulesetServiceDelegate>();
service_ = base::MakeUnique<RulesetService>(
- &pref_service_, task_runner_,
- base::WrapUnique(mock_delegate_ = new MockRulesetServiceDelegate),
- base_dir());
+ &pref_service_, task_runner_, mock_delegate_.get(), base_dir());
}
void ClearRulesetService() {
- mock_delegate_ = nullptr;
service_.reset();
+ mock_delegate_.reset();
}
// Creates a new file with the given license |contents| at a unique temporary
@@ -269,7 +267,7 @@ class SubresourceFilteringRulesetServiceTest : public ::testing::Test {
PrefService* prefs() { return &pref_service_; }
RulesetService* service() { return service_.get(); }
- MockRulesetServiceDelegate* mock_delegate() { return mock_delegate_; }
+ MockRulesetServiceDelegate* mock_delegate() { return mock_delegate_.get(); }
virtual base::FilePath effective_temp_dir() const {
return scoped_temp_dir_.GetPath();
@@ -295,8 +293,8 @@ class SubresourceFilteringRulesetServiceTest : public ::testing::Test {
TestRulesetPair test_ruleset_2_;
TestRulesetPair test_ruleset_3_;
+ std::unique_ptr<MockRulesetServiceDelegate> mock_delegate_;
std::unique_ptr<RulesetService> service_;
- MockRulesetServiceDelegate* mock_delegate_; // Weak, owned by |service_|.
DISALLOW_COPY_AND_ASSIGN(SubresourceFilteringRulesetServiceTest);
};
« no previous file with comments | « components/subresource_filter/core/browser/ruleset_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698