Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Unified Diff: chrome/browser/component_updater/subresource_filter_component_installer_unittest.cc

Issue 2731283009: Swap ownership of RulesetService and the content delegate (Closed)
Patch Set: engedy review Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/subresource_filter_component_installer_unittest.cc
diff --git a/chrome/browser/component_updater/subresource_filter_component_installer_unittest.cc b/chrome/browser/component_updater/subresource_filter_component_installer_unittest.cc
index 2599c8c746b51f1b3b22aee4e40718b3080d54c8..810c57f31d49b1e1a8d3b13cf94c562788ea8651 100644
--- a/chrome/browser/component_updater/subresource_filter_component_installer_unittest.cc
+++ b/chrome/browser/component_updater/subresource_filter_component_installer_unittest.cc
@@ -22,7 +22,7 @@
#include "chrome/test/base/testing_browser_process.h"
#include "components/component_updater/mock_component_updater_service.h"
#include "components/prefs/testing_pref_service.h"
-#include "components/subresource_filter/content/browser/content_ruleset_service_delegate.h"
+#include "components/subresource_filter/content/browser/content_ruleset_service.h"
#include "components/subresource_filter/core/browser/ruleset_service.h"
#include "components/subresource_filter/core/browser/subresource_filter_constants.h"
#include "components/subresource_filter/core/browser/subresource_filter_features.h"
@@ -39,13 +39,12 @@ class TestRulesetService : public subresource_filter::RulesetService {
public:
TestRulesetService(PrefService* local_state,
scoped_refptr<base::SequencedTaskRunner> task_runner,
+ subresource_filter::ContentRulesetService* content_service,
const base::FilePath& base_dir)
- : subresource_filter::RulesetService(
- local_state,
- task_runner,
- base::MakeUnique<
- subresource_filter::ContentRulesetServiceDelegate>(),
- base_dir) {}
+ : subresource_filter::RulesetService(local_state,
+ task_runner,
+ content_service,
+ base_dir) {}
~TestRulesetService() override {}
@@ -103,19 +102,20 @@ class SubresourceFilterComponentInstallerTest : public PlatformTest {
subresource_filter::IndexedRulesetVersion::RegisterPrefs(
pref_service_.registry());
- std::unique_ptr<subresource_filter::RulesetService> service(
- new TestRulesetService(&pref_service_, task_runner_,
- ruleset_service_dir_.GetPath()));
+ auto content_service =
+ base::MakeUnique<subresource_filter::ContentRulesetService>();
+ auto test_ruleset_service = base::MakeUnique<TestRulesetService>(
+ &pref_service_, task_runner_, content_service.get(),
+ ruleset_service_dir_.GetPath());
+ test_ruleset_service_ = test_ruleset_service.get();
+ content_service->set_ruleset_service(std::move(test_ruleset_service));
- TestingBrowserProcess::GetGlobal()->SetRulesetService(std::move(service));
+ TestingBrowserProcess::GetGlobal()->SetRulesetService(
+ std::move(content_service));
traits_.reset(new SubresourceFilterComponentInstallerTraits());
}
- TestRulesetService* service() {
- return static_cast<TestRulesetService*>(
- TestingBrowserProcess::GetGlobal()
- ->subresource_filter_ruleset_service());
- }
+ TestRulesetService* service() { return test_ruleset_service_; }
void WriteStringToFile(const std::string data, const base::FilePath& path) {
ASSERT_EQ(static_cast<int32_t>(data.length()),
@@ -179,6 +179,8 @@ class SubresourceFilterComponentInstallerTest : public PlatformTest {
scoped_refptr<base::TestSimpleTaskRunner> task_runner_;
TestingPrefServiceSimple pref_service_;
+ TestRulesetService* test_ruleset_service_ = nullptr;
+
DISALLOW_COPY_AND_ASSIGN(SubresourceFilterComponentInstallerTest);
};

Powered by Google App Engine
This is Rietveld 408576698