Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: chrome/browser/browser_process_impl.h

Issue 2731283009: Swap ownership of RulesetService and the content delegate (Closed)
Patch Set: engedy review Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/browser_process.h ('k') | chrome/browser/browser_process_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // When each service is created, we set a flag indicating this. At this point, 5 // When each service is created, we set a flag indicating this. At this point,
6 // the service initialization could fail or succeed. This allows us to remember 6 // the service initialization could fail or succeed. This allows us to remember
7 // if we tried to create a service, and not try creating it over and over if 7 // if we tried to create a service, and not try creating it over and over if
8 // the creation failed. 8 // the creation failed.
9 9
10 #ifndef CHROME_BROWSER_BROWSER_PROCESS_IMPL_H_ 10 #ifndef CHROME_BROWSER_BROWSER_PROCESS_IMPL_H_
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 void SetApplicationLocale(const std::string& locale) override; 126 void SetApplicationLocale(const std::string& locale) override;
127 DownloadStatusUpdater* download_status_updater() override; 127 DownloadStatusUpdater* download_status_updater() override;
128 DownloadRequestLimiter* download_request_limiter() override; 128 DownloadRequestLimiter* download_request_limiter() override;
129 BackgroundModeManager* background_mode_manager() override; 129 BackgroundModeManager* background_mode_manager() override;
130 void set_background_mode_manager_for_test( 130 void set_background_mode_manager_for_test(
131 std::unique_ptr<BackgroundModeManager> manager) override; 131 std::unique_ptr<BackgroundModeManager> manager) override;
132 StatusTray* status_tray() override; 132 StatusTray* status_tray() override;
133 safe_browsing::SafeBrowsingService* safe_browsing_service() override; 133 safe_browsing::SafeBrowsingService* safe_browsing_service() override;
134 safe_browsing::ClientSideDetectionService* safe_browsing_detection_service() 134 safe_browsing::ClientSideDetectionService* safe_browsing_detection_service()
135 override; 135 override;
136 subresource_filter::RulesetService* subresource_filter_ruleset_service() 136 subresource_filter::ContentRulesetService*
137 override; 137 subresource_filter_ruleset_service() override;
138 138
139 #if (defined(OS_WIN) || defined(OS_LINUX)) && !defined(OS_CHROMEOS) 139 #if (defined(OS_WIN) || defined(OS_LINUX)) && !defined(OS_CHROMEOS)
140 void StartAutoupdateTimer() override; 140 void StartAutoupdateTimer() override;
141 #endif 141 #endif
142 142
143 net_log::ChromeNetLog* net_log() override; 143 net_log::ChromeNetLog* net_log() override;
144 component_updater::ComponentUpdateService* component_updater() override; 144 component_updater::ComponentUpdateService* component_updater() override;
145 CRLSetFetcher* crl_set_fetcher() override; 145 CRLSetFetcher* crl_set_fetcher() override;
146 component_updater::PnaclComponentInstaller* pnacl_component_installer() 146 component_updater::PnaclComponentInstaller* pnacl_component_installer()
147 override; 147 override;
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 std::unique_ptr<NotificationPlatformBridge> notification_bridge_; 256 std::unique_ptr<NotificationPlatformBridge> notification_bridge_;
257 257
258 #if BUILDFLAG(ENABLE_BACKGROUND) 258 #if BUILDFLAG(ENABLE_BACKGROUND)
259 std::unique_ptr<BackgroundModeManager> background_mode_manager_; 259 std::unique_ptr<BackgroundModeManager> background_mode_manager_;
260 #endif 260 #endif
261 261
262 bool created_safe_browsing_service_; 262 bool created_safe_browsing_service_;
263 scoped_refptr<safe_browsing::SafeBrowsingService> safe_browsing_service_; 263 scoped_refptr<safe_browsing::SafeBrowsingService> safe_browsing_service_;
264 264
265 bool created_subresource_filter_ruleset_service_; 265 bool created_subresource_filter_ruleset_service_;
266 std::unique_ptr<subresource_filter::RulesetService> 266 std::unique_ptr<subresource_filter::ContentRulesetService>
267 subresource_filter_ruleset_service_; 267 subresource_filter_ruleset_service_;
268 268
269 bool shutting_down_; 269 bool shutting_down_;
270 270
271 bool tearing_down_; 271 bool tearing_down_;
272 272
273 // Ensures that all the print jobs are finished before closing the browser. 273 // Ensures that all the print jobs are finished before closing the browser.
274 std::unique_ptr<printing::PrintJobManager> print_job_manager_; 274 std::unique_ptr<printing::PrintJobManager> print_job_manager_;
275 275
276 std::string locale_; 276 std::string locale_;
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
350 350
351 shell_integration::DefaultWebClientState cached_default_web_client_state_; 351 shell_integration::DefaultWebClientState cached_default_web_client_state_;
352 352
353 std::unique_ptr<physical_web::PhysicalWebDataSource> 353 std::unique_ptr<physical_web::PhysicalWebDataSource>
354 physical_web_data_source_; 354 physical_web_data_source_;
355 355
356 DISALLOW_COPY_AND_ASSIGN(BrowserProcessImpl); 356 DISALLOW_COPY_AND_ASSIGN(BrowserProcessImpl);
357 }; 357 };
358 358
359 #endif // CHROME_BROWSER_BROWSER_PROCESS_IMPL_H_ 359 #endif // CHROME_BROWSER_BROWSER_PROCESS_IMPL_H_
OLDNEW
« no previous file with comments | « chrome/browser/browser_process.h ('k') | chrome/browser/browser_process_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698