Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: src/isolate.cc

Issue 2731273002: [debug] add exception predictions to builtins where missing. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/isolate.h" 5 #include "src/isolate.h"
6 6
7 #include <stdlib.h> 7 #include <stdlib.h>
8 8
9 #include <fstream> // NOLINT(readability/streams) 9 #include <fstream> // NOLINT(readability/streams)
10 #include <sstream> 10 #include <sstream>
(...skipping 1333 matching lines...) Expand 10 before | Expand all | Expand 10 after
1344 if (code->IsCode() && code->kind() == AbstractCode::BUILTIN) { 1344 if (code->IsCode() && code->kind() == AbstractCode::BUILTIN) {
1345 if (code->GetCode()->is_promise_rejection()) { 1345 if (code->GetCode()->is_promise_rejection()) {
1346 return HandlerTable::PROMISE; 1346 return HandlerTable::PROMISE;
1347 } 1347 }
1348 1348
1349 // This the exception throw in PromiseHandle which doesn't 1349 // This the exception throw in PromiseHandle which doesn't
1350 // cause a promise rejection. 1350 // cause a promise rejection.
1351 if (code->GetCode()->is_exception_caught()) { 1351 if (code->GetCode()->is_exception_caught()) {
1352 return HandlerTable::CAUGHT; 1352 return HandlerTable::CAUGHT;
1353 } 1353 }
1354
1355 // The built-in must be marked with an exception prediction.
1356 UNREACHABLE();
1354 } 1357 }
1355 1358
1356 if (code->kind() == AbstractCode::OPTIMIZED_FUNCTION) { 1359 if (code->kind() == AbstractCode::OPTIMIZED_FUNCTION) {
1357 DCHECK(summary.AsJavaScript().function()->shared()->asm_function()); 1360 DCHECK(summary.AsJavaScript().function()->shared()->asm_function());
1358 // asm code cannot contain try-catch. 1361 // asm code cannot contain try-catch.
1359 continue; 1362 continue;
1360 } 1363 }
1361 // Must have been constructed from a bytecode array. 1364 // Must have been constructed from a bytecode array.
1362 CHECK_EQ(AbstractCode::INTERPRETED_FUNCTION, code->kind()); 1365 CHECK_EQ(AbstractCode::INTERPRETED_FUNCTION, code->kind());
1363 int code_offset = summary.code_offset(); 1366 int code_offset = summary.code_offset();
(...skipping 2332 matching lines...) Expand 10 before | Expand all | Expand 10 after
3696 // Then check whether this scope intercepts. 3699 // Then check whether this scope intercepts.
3697 if ((flag & intercept_mask_)) { 3700 if ((flag & intercept_mask_)) {
3698 intercepted_flags_ |= flag; 3701 intercepted_flags_ |= flag;
3699 return true; 3702 return true;
3700 } 3703 }
3701 return false; 3704 return false;
3702 } 3705 }
3703 3706
3704 } // namespace internal 3707 } // namespace internal
3705 } // namespace v8 3708 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698