Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1148)

Side by Side Diff: content/browser/memory/memory_condition_observer.cc

Issue 2731233002: memory coordinator: Remove obsoleted variation parameters (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/memory/memory_condition_observer.h" 5 #include "content/browser/memory/memory_condition_observer.h"
6 6
7 #include "base/metrics/histogram_macros.h" 7 #include "base/metrics/histogram_macros.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "components/variations/variations_associated_data.h" 9 #include "components/variations/variations_associated_data.h"
10 #include "content/browser/memory/memory_monitor.h" 10 #include "content/browser/memory/memory_monitor.h"
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 new_renderers_until_critical_ = kDefaultNewRenderersUntilCritical; 128 new_renderers_until_critical_ = kDefaultNewRenderersUntilCritical;
129 new_renderers_back_to_normal_ = kDefaultNewRenderersBackToNormal; 129 new_renderers_back_to_normal_ = kDefaultNewRenderersBackToNormal;
130 new_renderers_back_to_warning_ = kDefaultNewRenderersBackToWarning; 130 new_renderers_back_to_warning_ = kDefaultNewRenderersBackToWarning;
131 monitoring_interval_ = 131 monitoring_interval_ =
132 base::TimeDelta::FromSeconds(kDefaultMonitoringIntervalSeconds); 132 base::TimeDelta::FromSeconds(kDefaultMonitoringIntervalSeconds);
133 133
134 // Override default parameters with variations. 134 // Override default parameters with variations.
135 static constexpr char kMemoryCoordinatorV0Trial[] = "MemoryCoordinatorV0"; 135 static constexpr char kMemoryCoordinatorV0Trial[] = "MemoryCoordinatorV0";
136 std::map<std::string, std::string> params; 136 std::map<std::string, std::string> params;
137 variations::GetVariationParams(kMemoryCoordinatorV0Trial, &params); 137 variations::GetVariationParams(kMemoryCoordinatorV0Trial, &params);
138 // TODO(bashi): Renaming (throttled -> warning, suspended -> critical) is
139 // ongoing. Get variation parameters from both until server-side change
140 // is done. crbug.com/696844
141 SetIntVariationParameter(params, "expected_renderer_size", 138 SetIntVariationParameter(params, "expected_renderer_size",
142 &expected_renderer_size_); 139 &expected_renderer_size_);
143 SetIntVariationParameter(params, "new_renderers_until_throttled",
144 &new_renderers_until_warning_);
145 SetIntVariationParameter(params, "new_renderers_until_warning", 140 SetIntVariationParameter(params, "new_renderers_until_warning",
146 &new_renderers_until_warning_); 141 &new_renderers_until_warning_);
147 SetIntVariationParameter(params, "new_renderers_until_suspended",
148 &new_renderers_until_critical_);
149 SetIntVariationParameter(params, "new_renderers_until_critical", 142 SetIntVariationParameter(params, "new_renderers_until_critical",
150 &new_renderers_until_critical_); 143 &new_renderers_until_critical_);
151 SetIntVariationParameter(params, "new_renderers_back_to_normal", 144 SetIntVariationParameter(params, "new_renderers_back_to_normal",
152 &new_renderers_back_to_normal_); 145 &new_renderers_back_to_normal_);
153 SetIntVariationParameter(params, "new_renderers_back_to_throttled",
154 &new_renderers_back_to_warning_);
155 SetIntVariationParameter(params, "new_renderers_back_to_warning", 146 SetIntVariationParameter(params, "new_renderers_back_to_warning",
156 &new_renderers_back_to_warning_); 147 &new_renderers_back_to_warning_);
157 SetSecondsVariationParameter(params, "monitoring_interval", 148 SetSecondsVariationParameter(params, "monitoring_interval",
158 &monitoring_interval_); 149 &monitoring_interval_);
159 } 150 }
160 151
161 bool MemoryConditionObserver::ValidateParameters() { 152 bool MemoryConditionObserver::ValidateParameters() {
162 return (new_renderers_until_warning_ > new_renderers_until_critical_) && 153 return (new_renderers_until_warning_ > new_renderers_until_critical_) &&
163 (new_renderers_back_to_normal_ > new_renderers_back_to_warning_) && 154 (new_renderers_back_to_normal_ > new_renderers_back_to_warning_) &&
164 (new_renderers_back_to_normal_ > new_renderers_until_warning_) && 155 (new_renderers_back_to_normal_ > new_renderers_until_warning_) &&
165 (new_renderers_back_to_warning_ > new_renderers_until_critical_); 156 (new_renderers_back_to_warning_ > new_renderers_until_critical_);
166 } 157 }
167 158
168 } // namespace content 159 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698