Add ClassEntity.library, MemberEntity.library and FunctionEntity.isExternal

Add ClassEntity.library, MemberEntity.library and FunctionEntity.isExternal

- and mostly use entities in native_data.dart

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/8e1e08ce4aa76f078ae7ce0231b395edf69878e8

[Johnni Winther, 2017-03-05 13:55:50]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-03-14 04:54:59]

lgtm

https://codereview.chromium.org/2731173002/diff/1/pkg/compiler/lib/src/elemen...
File pkg/compiler/lib/src/elements/entities.dart (right):

https://codereview.chromium.org/2731173002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/entities.dart:38: /// `true` if a synthesized
class for a closurized method or local function.
nit: if a => if this is a ?

https://codereview.chromium.org/2731173002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/entities.dart:57: /// `true` if this is a member
of a library.
(optional) I tend to use the form "Whether ..." instead of "`true` if ...", for
example:

  Whether this is a member of a library.

Feel free to keep as it is or change it if that's your preference too :)

https://codereview.chromium.org/2731173002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/entities.dart:89: /// The enclosing library if
this is a library member, other wise the
other wise => otherwise

https://codereview.chromium.org/2731173002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/entities.dart:106: /// of Dart code.
... and it is marked with the 'external' modifier keyword?

[Johnni Winther, 2017-03-15 12:07:09]

https://codereview.chromium.org/2731173002/diff/1/pkg/compiler/lib/src/elemen...
File pkg/compiler/lib/src/elements/entities.dart (right):

https://codereview.chromium.org/2731173002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/entities.dart:38: /// `true` if a synthesized
class for a closurized method or local function.
On 2017/03/14 04:54:59, Siggi Cherem (dart-lang) wrote:
> nit: if a => if this is a ?

Done.

https://codereview.chromium.org/2731173002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/entities.dart:57: /// `true` if this is a member
of a library.
On 2017/03/14 04:54:59, Siggi Cherem (dart-lang) wrote:
> (optional) I tend to use the form "Whether ..." instead of "`true` if ...",
for
> example:
> 
>   Whether this is a member of a library.
> 
> Feel free to keep as it is or change it if that's your preference too :)

Done.

https://codereview.chromium.org/2731173002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/entities.dart:89: /// The enclosing library if
this is a library member, other wise the
On 2017/03/14 04:54:59, Siggi Cherem (dart-lang) wrote:
> other wise => otherwise

Done.

https://codereview.chromium.org/2731173002/diff/1/pkg/compiler/lib/src/elemen...
pkg/compiler/lib/src/elements/entities.dart:106: /// of Dart code.
On 2017/03/14 04:54:59, Siggi Cherem (dart-lang) wrote:
> ... and it is marked with the 'external' modifier keyword?

That should be only one way to define it. A JElement could be external
(JElements for native methods should be external regardless how we specify them
in Dart).

[Johnni Winther, 2017-03-15 12:18:37]

Description was changed from

==========
Add ClassEntity.library, MemberEntity.library and FunctionEntity.isExternal

- and mostly use entities in native_data.dart
==========

to

==========
Add ClassEntity.library, MemberEntity.library and FunctionEntity.isExternal

- and mostly use entities in native_data.dart

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8e1e08ce4aa76f078ae7ce0231b395edf69878e8
==========

[Johnni Winther, 2017-03-15 12:18:39]

Committed patchset #2 (id:20001) manually as
8e1e08ce4aa76f078ae7ce0231b395edf69878e8 (presubmit successful).