Split js interop registration into library/class/member elements

Split js interop registration into library/class/member elements

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/fbbf1e90ec0d48d0c6eaeffc194ddfbfdb07e8cd

[Johnni Winther, 2017-03-05 13:55:41]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-03-14 04:48:20]

lgtm

https://codereview.chromium.org/2731163002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/native_data.dart (right):

https://codereview.chromium.org/2731163002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/native_data.dart:71: /// Computes the name
prefix for [element to use in the generated JavaScript.
nit: add missing ]

https://codereview.chromium.org/2731163002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/native_data.dart:73: /// names for the library
and/or the enclosing class.
might be worth clarifying that here you mean JS names for the library/enclosing
class?: (from their given js names, not the default Dart names I assume?)

https://codereview.chromium.org/2731163002/diff/20001/pkg/compiler/lib/src/ty...
File pkg/compiler/lib/src/types/types.dart (right):

https://codereview.chromium.org/2731163002/diff/20001/pkg/compiler/lib/src/ty...
pkg/compiler/lib/src/types/types.dart:213: // TODO(johnniwinther): Can we meet
classes here?
I was wondering the same thing...

[Johnni Winther, 2017-03-15 11:42:15]

https://codereview.chromium.org/2731163002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/native_data.dart (right):

https://codereview.chromium.org/2731163002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/native_data.dart:71: /// Computes the name
prefix for [element to use in the generated JavaScript.
On 2017/03/14 04:48:19, Siggi Cherem (dart-lang) wrote:
> nit: add missing ]

Done.

https://codereview.chromium.org/2731163002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/native_data.dart:73: /// names for the library
and/or the enclosing class.
On 2017/03/14 04:48:19, Siggi Cherem (dart-lang) wrote:
> might be worth clarifying that here you mean JS names for the
library/enclosing
> class?: (from their given js names, not the default Dart names I assume?)

Done.

[Johnni Winther, 2017-03-15 11:59:01]

Description was changed from

==========
Split js interop registration into library/class/member elements
==========

to

==========
Split js interop registration into library/class/member elements

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/fbbf1e90ec0d48d0c6eaeffc194ddfbfdb07e8cd
==========

[Johnni Winther, 2017-03-15 11:59:03]

Committed patchset #3 (id:40001) manually as
fbbf1e90ec0d48d0c6eaeffc194ddfbfdb07e8cd (presubmit successful).