Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 273113005: Remove ViewHostMsg_UpdateIsDelayed (Closed)

Created:
6 years, 7 months ago by piman
Modified:
6 years, 7 months ago
Reviewers:
palmer, ccameron
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Remove ViewHostMsg_UpdateIsDelayed This message can only affect RenderWidgetHostImpl::WaitForSurface, which is only called on Mac. However, it is never sent on mac. So just remove it. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269685

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -49 lines) Patch
M content/browser/renderer_host/render_message_filter.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 4 chunks +1 line, -10 lines 0 comments Download
M content/common/swapped_out_messages.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/view_messages.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
piman
ccameron: please review palmer: security for view_messages.h (removing an IPC)
6 years, 7 months ago (2014-05-09 23:41:38 UTC) #1
palmer
IPC security LGTM.
6 years, 7 months ago (2014-05-10 01:04:03 UTC) #2
ccameron
lgtm
6 years, 7 months ago (2014-05-10 06:24:09 UTC) #3
piman
The CQ bit was checked by piman@chromium.org
6 years, 7 months ago (2014-05-10 18:17:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/273113005/1
6 years, 7 months ago (2014-05-10 18:18:09 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-10 19:51:33 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-11 01:43:36 UTC) #7
Message was sent while issue was closed.
Change committed as 269685

Powered by Google App Engine
This is Rietveld 408576698