Issue 273113004: Make CompositorImpl::CompositeAndReadback fail and return false.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 273113004: Make CompositorImpl::CompositeAndReadback fail and return false. (Closed)

Created:
6 years, 7 months ago by danakj

Modified:
6 years, 7 months ago

Reviewers:
powei, piman

CC:
chromium-reviews, darin-cc_chromium.org, jam, brianderson, enne (OOO), piman, aelias_OOO_until_Jul13

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make CompositorImpl::CompositeAndReadback fail and return false. Removes the call to LayerTreeHost::CompositeAndReadback and just fail immediately. This method should be replaced with an async readback in order to get pixels again. R=powei BUG=252046 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269931

Patch Set 1 : compositor-impl-cnr-false: #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	content/browser/renderer_host/compositor_impl_android.cc	View		1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/273113004/1

6 years, 7 months ago (2014-05-12 23:22:52 UTC) #7

danakj

6 years, 7 months ago (2014-05-13 19:32:13 UTC) #9

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/284733005/ by danakj@chromium.org.

The reason for reverting is: Seems like this broke android pixel tests also:
https://code.google.com/p/chromium/issues/detail?id=372562.

Expand Messages | Collapse Messages