Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1507)

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.h

Issue 2731123002: Fix some issues with OmniboxViewViews' use of OmniboxClient. (Closed)
Patch Set: Resync Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/omnibox/omnibox_view_views.h
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.h b/chrome/browser/ui/views/omnibox/omnibox_view_views.h
index c344e4a31099c53bdb6128999e3305d913d8ce33..5184a7da22ab72e1011fec4b44ab32da4456626f 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.h
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.h
@@ -28,7 +28,6 @@
class CommandUpdater;
class LocationBarView;
class OmniboxPopupView;
-class Profile;
namespace content {
class WebContents;
@@ -56,7 +55,7 @@ class OmniboxViewViews
static const char kViewClassName[];
OmniboxViewViews(OmniboxEditController* controller,
- Profile* profile,
+ std::unique_ptr<OmniboxClient> client,
Mark P 2017/03/08 05:43:38 nit: please add appropriate include or forward dec
Peter Kasting 2017/03/08 11:44:57 Done, though in the absence of formal IWYU tooling
CommandUpdater* command_updater,
bool popup_window_mode,
LocationBarView* location_bar,
@@ -200,8 +199,6 @@ class OmniboxViewViews
int OnDrop(const ui::OSExchangeData& data) override;
void UpdateContextMenu(ui::SimpleMenuModel* menu_contents) override;
- Profile* profile_;
-
// When true, the location bar view is read only and also is has a slightly
// different presentation (smaller font size). This is used for popups.
bool popup_window_mode_;

Powered by Google App Engine
This is Rietveld 408576698