Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2412)

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.h

Issue 2731123002: Fix some issues with OmniboxViewViews' use of OmniboxClient. (Closed)
Patch Set: Review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/omnibox/omnibox_view_views.h
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.h b/chrome/browser/ui/views/omnibox/omnibox_view_views.h
index c344e4a31099c53bdb6128999e3305d913d8ce33..744740ef55bb4308ffca7b96b17bda7d72adceb1 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.h
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.h
@@ -27,8 +27,8 @@
class CommandUpdater;
class LocationBarView;
+class OmniboxClient;
class OmniboxPopupView;
-class Profile;
namespace content {
class WebContents;
@@ -56,7 +56,7 @@ class OmniboxViewViews
static const char kViewClassName[];
OmniboxViewViews(OmniboxEditController* controller,
- Profile* profile,
+ std::unique_ptr<OmniboxClient> client,
CommandUpdater* command_updater,
bool popup_window_mode,
LocationBarView* location_bar,
@@ -200,8 +200,6 @@ class OmniboxViewViews
int OnDrop(const ui::OSExchangeData& data) override;
void UpdateContextMenu(ui::SimpleMenuModel* menu_contents) override;
- Profile* profile_;
-
// When true, the location bar view is read only and also is has a slightly
// different presentation (smaller font size). This is used for popups.
bool popup_window_mode_;
« no previous file with comments | « chrome/browser/ui/views/location_bar/location_bar_view.cc ('k') | chrome/browser/ui/views/omnibox/omnibox_view_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698