Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1315)

Unified Diff: chrome/browser/ui/website_settings/permission_menu_model.cc

Issue 2731083002: Stop pretending that a Flash setting of DETECT_IMPORTANT_CONTENT is ASK.
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/permission_menu_model.cc
diff --git a/chrome/browser/ui/website_settings/permission_menu_model.cc b/chrome/browser/ui/website_settings/permission_menu_model.cc
index 2828c7794e27a189cfad904b21bdac84be5c0a9e..b28b783e034a4c32ea82cf4fd6edca6019f3b434 100644
--- a/chrome/browser/ui/website_settings/permission_menu_model.cc
+++ b/chrome/browser/ui/website_settings/permission_menu_model.cc
@@ -53,9 +53,7 @@ PermissionMenuModel::PermissionMenuModel(
// HTML5 by Default, Chrome will ask before running Flash on most sites.
// Once the feature flag is gone, migrate the actual setting to ASK.
raymes 2017/03/05 23:56:50 I think this TODO is inaccurate now?
tommycli 2017/03/06 19:10:26 Yes that's right. it's inaccurate. Though maybe it
label = l10n_util::GetStringUTF16(
- PluginUtils::ShouldPreferHtmlOverPlugins(host_content_settings_map_)
- ? IDS_WEBSITE_SETTINGS_MENU_ITEM_DEFAULT_ASK
- : IDS_WEBSITE_SETTINGS_MENU_ITEM_DEFAULT_DETECT_IMPORTANT_CONTENT);
+ IDS_WEBSITE_SETTINGS_MENU_ITEM_DEFAULT_DETECT_IMPORTANT_CONTENT);
break;
case CONTENT_SETTING_NUM_SETTINGS:
NOTREACHED();

Powered by Google App Engine
This is Rietveld 408576698