[Media Router] Custom Controls 3 - add plumbing through MRUI and MRWebUIMessageHandler

chrome/common/chrome_features.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/chrome_features.h"
 
 #include "base/command_line.h"
 #include "chrome/common/chrome_switches.h"
 #include "extensions/features/features.h"
 #include "ppapi/features/features.h"
@@ skipping 187 matching lines @@
                                             base::FEATURE_ENABLED_BY_DEFAULT};
 
 #if !defined(OS_ANDROID) && !defined(OS_IOS)
 // Enables media content bitstream remoting, an optimization that can activate
 // during Cast Tab Mirroring. When kMediaRemotingEncrypted is disabled, the
 // feature will not activate for encrypted content.
 const base::Feature kMediaRemoting{"MediaRemoting",
                                    base::FEATURE_DISABLED_BY_DEFAULT};
 const base::Feature kMediaRemotingEncrypted{"MediaRemotingEncrypted",
                                             base::FEATURE_DISABLED_BY_DEFAULT};
+
+// Replaces the current route details view in the Media Router dialog provided

[imcheng, 2017/04/22 00:22:51]

I would probably phrase it as:

If enabled, replaces the <extensionview> controller in the route details view of
the Media Router dialog with the controller bundled with the WebUI resources.

[takumif, 2017/04/24 20:59:23]

Done.

+// by the Media Router component extension with one provided by Chromium that
+// does not use <extensionview>.
+const base::Feature kMediaRouterNewRouteController{
+    // TODO: Do FEATURE_DISABLED_BY_DEFAULT instead

[imcheng, 2017/04/22 00:22:51]

Resolve TODO?

[takumif, 2017/04/24 20:59:23]

Done.

+    "MediaRouterNewRouteController", base::FEATURE_ENABLED_BY_DEFAULT};
 #endif  // !defined(OS_ANDROID) && !defined(OS_IOS)
 
 // Enables or disables modal permission prompts.
 const base::Feature kModalPermissionPrompts{"ModalPermissionPrompts",
                                             base::FEATURE_DISABLED_BY_DEFAULT};
 
 #if defined(OS_WIN)
 // Enables or disables the ModuleDatabase backend for the conflicts UI.
 const base::Feature kModuleDatabase{"ModuleDatabase",
                                     base::FEATURE_DISABLED_BY_DEFAULT};
@@ skipping 118 matching lines @@
   return base::FeatureList::IsEnabled(features::kPrefService) ||
 #if BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES)
          base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
              switches::kMusConfig) == switches::kMash;
 #else
          false;
 #endif
 }
 
 }  // namespace features