tools/perf/metrics/timeline.py - Issue 273103003: Add responsiveness_metric for timeline_based_measurement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/metrics/timeline.py

Issue 273103003: Add responsiveness_metric for timeline_based_measurement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Chris's comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/metrics/timeline.py

diff --git a/tools/perf/metrics/timeline.py b/tools/perf/metrics/timeline.py

index c52435242670f2eb0d8e2238ccda4685d277a3b8..cfb24904897f2304d8935696a8fb439a1d97f175 100644

--- a/tools/perf/metrics/timeline.py

+++ b/tools/perf/metrics/timeline.py

@@ -31,8 +31,8 @@ class LoadTimesTimelineMetric(timeline_based_metric.TimelineBasedMetric):

continue

thread_name = thread.name.replace('/','_')

- for e in thread.IterAllSlicesInRange(interaction_record.start,

- interaction_record.end):

+ for e in thread.IterAllSlicesInTimeRange(interaction_record.start,

+ interaction_record.end):

events_by_name[e.name].append(e)

for event_name, event_group in events_by_name.iteritems():

« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/timeline/thread.py » ('j') | tools/telemetry/telemetry/web_perf/metrics/mainthread_jank.py » ('J')