Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: tools/telemetry/telemetry/web_perf/timeline_interaction_record_unittest.py

Issue 273103003: Add responsiveness_metric for timeline_based_measurement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Chris' comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/web_perf/timeline_interaction_record_unittest.py
diff --git a/tools/telemetry/telemetry/web_perf/timeline_interaction_record_unittest.py b/tools/telemetry/telemetry/web_perf/timeline_interaction_record_unittest.py
index 3623217d30e4a6f1877a5f9e8e8f7f421ae73056..fc4adac595ae432a4cde90a28e97ad72cf698bf5 100644
--- a/tools/telemetry/telemetry/web_perf/timeline_interaction_record_unittest.py
+++ b/tools/telemetry/telemetry/web_perf/timeline_interaction_record_unittest.py
@@ -27,30 +27,30 @@ class ParseTests(unittest.TestCase):
r = self.CreateRecord('Interaction.LogicalName')
self.assertEquals('LogicalName', r.logical_name)
self.assertEquals(False, r.is_smooth)
- self.assertEquals(False, r.is_loading_resources)
+ self.assertEquals(False, r.is_responsive)
r = self.CreateRecord('Interaction.LogicalName/is_smooth')
self.assertEquals('LogicalName', r.logical_name)
self.assertEquals(True, r.is_smooth)
- self.assertEquals(False, r.is_loading_resources)
+ self.assertEquals(False, r.is_responsive)
r = self.CreateRecord('Interaction.LogicalNameWith/Slash/is_smooth')
self.assertEquals('LogicalNameWith/Slash', r.logical_name)
self.assertEquals(True, r.is_smooth)
- self.assertEquals(False, r.is_loading_resources)
+ self.assertEquals(False, r.is_responsive)
r = self.CreateRecord(
- 'Interaction.LogicalNameWith/Slash/is_smooth,is_loading_resources')
+ 'Interaction.LogicalNameWith/Slash/is_smooth,is_responsive')
self.assertEquals('LogicalNameWith/Slash', r.logical_name)
self.assertEquals(True, r.is_smooth)
- self.assertEquals(True, r.is_loading_resources)
+ self.assertEquals(True, r.is_responsive)
def testGetJavascriptMarker(self):
smooth_marker = tir_module.TimelineInteractionRecord.GetJavascriptMarker(
'LogicalName', [tir_module.IS_SMOOTH])
self.assertEquals('Interaction.LogicalName/is_smooth', smooth_marker)
slr_marker = tir_module.TimelineInteractionRecord.GetJavascriptMarker(
- 'LogicalName', [tir_module.IS_SMOOTH, tir_module.IS_LOADING_RESOURCES])
- self.assertEquals('Interaction.LogicalName/is_smooth,is_loading_resources',
+ 'LogicalName', [tir_module.IS_SMOOTH, tir_module.IS_RESPONSIVE])
+ self.assertEquals('Interaction.LogicalName/is_smooth,is_responsive',
slr_marker)

Powered by Google App Engine
This is Rietveld 408576698